Page MenuHomePhabricator

Site.loadrevisions rollback uses deprecated rvtoken parameter, used by revertbot
Closed, ResolvedPublic

Description

Calling Site.loadrevisions with rollback=True activates code that uses the deprecated parameter rvtoken, resulting in:

WARNING: API warning (revisions): The rvtoken parameter has been deprecated.

This parameter is indirectly used by revertbot option 'rollback', via Page.fullVersionHistory


Version: core-(2.0)
Severity: normal

Details

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:49 AM
bzimport set Reference to bz72763.
bzimport added a subscriber: Unknown Object (????).

gerritadmin wrote:

Change 170022 had a related patch set uploaded by John Vandenberg:
Add sysop test for loadrevisions rollback=True

https://gerrit.wikimedia.org/r/170022

gerritadmin wrote:

Change 170022 merged by jenkins-bot:
Add sysop test for loadrevisions rollback=True

https://gerrit.wikimedia.org/r/170022

This is still an issue, I can confirm it and reproduce it as well

>>> s.loadrevisions(page=py.Page(s, 'user:xqt/Test'), total='3', rollback=True)
WARNING: API warning (main): Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes. Use [[Special:ApiFeatureUsage]] to see usage of deprecated features by your application.
WARNING: API warning (revisions): The parameter "rvtoken" has been deprecated.
WARNING: API warning (revisions): Action "rollback" is not allowed for the current user.

Change 572922 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [cleanup] Remove deprecated "rvtoken"

https://gerrit.wikimedia.org/r/572922

Xqt triaged this task as Low priority.Feb 18 2020, 5:52 PM

Change 572922 merged by jenkins-bot:
[pywikibot/core@master] [cleanup] Remove deprecated "rvtoken"

https://gerrit.wikimedia.org/r/572922

Xqt claimed this task.