Page MenuHomePhabricator

Undefined property: stdClass::$page_touched in ApiPageSet.php on line 712
Closed, ResolvedPublic

Description

a lot of such notices in the hhvm.log though this is probably not hhvm-specific.

Undefined property: stdClass::$page_touched in /srv/mediawiki/php-1.25wmf5/includes/api/ApiPageSet.php on line 712


Version: unspecified
Severity: normal

Details

Reference
bz72764

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz72764.
aude created this task.Oct 30 2014, 2:15 PM

I found three things that could cause this bug (although as far as I can tell only the third actually is). Patches coming.

gerritadmin wrote:

Change 170093 had a related patch set uploaded by Anomie:
Correctly populate pageset in ApiQueryGeoSearchElastic

https://gerrit.wikimedia.org/r/170093

gerritadmin wrote:

Change 170094 had a related patch set uploaded by Anomie:
API: Add doc warning to ApiPageSet::populateFromQueryResult

https://gerrit.wikimedia.org/r/170094

gerritadmin wrote:

Change 170095 had a related patch set uploaded by Anomie:
API: Fix simplified continuation module skipping

https://gerrit.wikimedia.org/r/170095

(In reply to Brad Jorsch from comment #1)

I found three things that could cause this bug (although as far as I can
tell only the third actually is). Patches coming.

After further review, it turned out one of the things wasn't actually a bug. Still, two things.

gerritadmin wrote:

Change 170093 merged by jenkins-bot:
Correctly populate pageset in ApiQueryGeoSearchElastic

https://gerrit.wikimedia.org/r/170093

gerritadmin wrote:

Change 170094 merged by jenkins-bot:
API: Add doc warning to ApiPageSet::populateFromQueryResult

https://gerrit.wikimedia.org/r/170094

gerritadmin wrote:

Change 170095 merged by jenkins-bot:
API: Fix simplified continuation module skipping

https://gerrit.wikimedia.org/r/170095

Anomie added a comment.Nov 3 2014, 2:54 PM

Should be fixed with 1.25wmf7.

gerritadmin wrote:

Change 171774 had a related patch set uploaded by Reedy:
API: Add doc warning to ApiPageSet::populateFromQueryResult

https://gerrit.wikimedia.org/r/171774

gerritadmin wrote:

Change 171775 had a related patch set uploaded by Reedy:
API: Fix simplified continuation module skipping

https://gerrit.wikimedia.org/r/171775

gerritadmin wrote:

Change 171776 had a related patch set uploaded by Reedy:
Correctly populate pageset in ApiQueryGeoSearchElastic

https://gerrit.wikimedia.org/r/171776

gerritadmin wrote:

Change 171776 merged by jenkins-bot:
Correctly populate pageset in ApiQueryGeoSearchElastic

https://gerrit.wikimedia.org/r/171776

gerritadmin wrote:

Change 171774 merged by jenkins-bot:
API: Add doc warning to ApiPageSet::populateFromQueryResult

https://gerrit.wikimedia.org/r/171774

gerritadmin wrote:

Change 171775 merged by jenkins-bot:
API: Fix simplified continuation module skipping

https://gerrit.wikimedia.org/r/171775