Page MenuHomePhabricator

Code shouldn't be loaded unless necessary
Closed, ResolvedPublic

Description

mobile.newusers ResourceLoader module is loaded unconditionally. If you look closely it only does something when you are logged in.

Thus we should move all the logic for loading this code in php and not load it unless strictly necessary.

The module should be tagged with group other to lead to better caching.


Version: unspecified
Severity: normal

Details

Reference
bz72799

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz72799.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/uVypROVA

gerritadmin wrote:

Change 170878 had a related patch set uploaded by Jdlrobson:
Conditionally load mobile.newuser code

https://gerrit.wikimedia.org/r/170878

gerritadmin wrote:

Change 170878 merged by jenkins-bot:
Conditionally load mobile.newuser code

https://gerrit.wikimedia.org/r/170878

All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

gerritadmin wrote:

Change 173532 had a related patch set uploaded by Florianschmidtwelzow:
Don't load talk overlay code on talk pages

https://gerrit.wikimedia.org/r/173532

gerritadmin wrote:

Change 173532 merged by jenkins-bot:
Don't load talk overlay code on talk pages

https://gerrit.wikimedia.org/r/173532