Page MenuHomePhabricator

Page should not be reloaded if the user press ESC to close the "Link with page" popup
Open, LowPublic

Description

On
https://pt.wikipedia.org/wiki/Template:Country_flag_IOC_alias_IRQ?uselang=en
I followed these steps:

  1. Add links
  2. Language: en
  3. Page: Template:Country flag IOC alias IRQ
  4. Link with page
  5. Confirm

At this point, a popup appeared with a button "Close dialog and reload page".

When I pressed ESC, it reloaded the page instead of just closing the popup.


Version: unspecified
Severity: minor
Whiteboard: u=dev c=frontend p=0

Details

Reference
bz72807

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:52 AM
bzimport set Reference to bz72807.
bzimport added a subscriber: Unknown Object (MLST).
He7d3r created this task.Oct 31 2014, 11:01 AM

Change 171868 had a related patch set uploaded by Hoo man:
Allow submitting linkItem form with enter

https://gerrit.wikimedia.org/r/171868

hoo added a comment.Nov 7 2014, 6:53 PM

Accidentally uploaded a change with the wrong bug number.

hoo added a comment.Nov 7 2014, 6:55 PM

The page is being refreshed on all popup closes (after successful linking) on purpose, I'm not sure we want to change this. It might be confusing for people to see that their newly added links aren't there.

Why would someone press ESC to ADD something if it is usually used "in dialog boxes for No, Quit, Exit, Cancel, or Abort"
https://en.wikipedia.org/w/index.php?title=Esc_key#Uses

hoo added a comment.Nov 8 2014, 12:17 AM

(In reply to Helder from comment #4)

Why would someone press ESC to ADD something if it is usually used "in
dialog boxes for No, Quit, Exit, Cancel, or Abort"
https://en.wikipedia.org/w/index.php?title=Esc_key#Uses

You can abort/ cancel that action at that point, that should be shown to the user.

hoo added a comment.Nov 8 2014, 12:17 AM

(In reply to Helder from comment #4)

Why would someone press ESC to ADD something if it is usually used "in
dialog boxes for No, Quit, Exit, Cancel, or Abort"
https://en.wikipedia.org/w/index.php?title=Esc_key#Uses

You can't abort/ cancel that action at that point, that should be shown to the user.

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher lowered the priority of this task from Medium to Low.Dec 27 2014, 8:30 PM
Lydia_Pintscher set Security to None.

It should also not reload if clicked the close button (x) on upper right of the dialog box.

We have provided the close and reload page button, if user choose to ignore it, we should respect that choice.
I often choose to add a link and then click on another link (either edit this page, go to another page), it is a hassle for me.

See also: https://phabricator.wikimedia.org/T61156

XXN added a subscriber: XXN.May 16 2017, 10:55 AM