Page MenuHomePhabricator

VisualEditor: Allowing creation of empty caption moves the column editing icon at the top of the empty space which looks odd
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Insert a table
2.Insert an empty caption to the table
3.Save the page
4.Now select any cell in the table

Observe that,the column editing icon at the top of the empty space which looks odd

See the screenshot attached


Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-10-31_at_12.47.23_PM.png (326×381 px, 12 KB)

Details

Reference
bz72829

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:54 AM
bzimport set Reference to bz72829.

(In reply to Rummana Yasmeen from comment #0)

3.Save the page
4.Now select any cell in the table

Not necessary, this is immediately visible when you add the empty caption and move selection back to a table cell.

To the unfortunate soul tasked with resolving this: there exists a CSS
'caption-side' property, which allows the caption to be placed on every of the four usual sides (at least on Firefox, Chrome only supports 'top' and 'bottom'). (It is also supposed to accept a number of other unorthodox values, but it seems no one cares much about those.)

gerritadmin wrote:

Change 172191 had a related patch set uploaded by Bartosz Dziewoński:
TableNode, TableContext: Position row/column overlays better when caption is present

https://gerrit.wikimedia.org/r/172191

(In reply to Bartosz Dziewoński from comment #2)

To the unfortunate soul tasked with resolving this

Nevermind, it was fun.

gerritadmin wrote:

Change 172225 had a related patch set uploaded by Esanders:
Position the table context relative to the first section node

https://gerrit.wikimedia.org/r/172225

gerritadmin wrote:

Change 172191 abandoned by Bartosz Dziewoński:
TableNode: Position row/column overlays better when caption is present

Reason:
Superseded by I3d790d71

https://gerrit.wikimedia.org/r/172191

gerritadmin wrote:

Change 172225 merged by jenkins-bot:
Position the table context relative to the first section node

https://gerrit.wikimedia.org/r/172225

Verified the fix in Betalabs and test2

Verified the fix in production