Page MenuHomePhabricator

Title::isValidMoveOperation() no longer respects $auth parameter
Closed, ResolvedPublic

Description

Running our integration test [0] against master before the "Fully replace Title::moveTo() with MovePage" [1] merge does return a null revision for a moved page (using "WikiPage::factory( $oldTitle )->getRevision()for verification) but after the merge the old title still has a revision.

This breaks our integration tests for MW 1.25 after [1] while tests before that and those on MW 1.24/MW 1.23/MW 1.21 do work as specified and expected.

[0] SMW\Tests\Integration\MediaWiki\Hooks\TitleMoveCompleteIntegrationTest::testPageMoveWithCreationOfRedirectTarget

Failed asserting that null is not null.

[1] https://github.com/wikimedia/mediawiki/commit/ac53e45035e7b7ea22e123b404608e5e699024be


Version: 1.25-git
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:57 AM
bzimport set Reference to bz72870.
bzimport added a subscriber: Unknown Object (MLST).

Ic5026384b92a0d68d628397ffe1de6e5b6183f02

Legoktm triaged this task as High priority.Feb 5 2015, 4:56 PM
Legoktm added a project: MW-1.25-release.
Legoktm set Security to None.

This is because Title::isValidMoveOperation() no longer checks the value of the $auth parameter, so the test is probably returning an error with permission failures. I submitted https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/788 to make this easier to detect in the future.

Legoktm renamed this task from TitleMoveComplete hook is broken after (ac53e4503) to Title::isValidMoveOperation() no longer respects $auth parameter.Feb 5 2015, 6:37 PM
gerritbot added a subscriber: gerritbot.

Change 188847 had a related patch set uploaded (by Legoktm):
Check $auth parameter in Title::isValidMoveOperation()

https://gerrit.wikimedia.org/r/188847

Patch-For-Review

Change 188847 merged by jenkins-bot:
Check $auth parameter in Title::isValidMoveOperation()

https://gerrit.wikimedia.org/r/188847