Page MenuHomePhabricator

reset called on null in getCreatorsFromPostIDs because post not found, in Thanks tests
Closed, ResolvedPublic

Description

This is breaking Thanks tests: https://integration.wikimedia.org/ci/job/mwext-Thanks-testextension/24/consoleFull

$storage->find above it is apparently not finding the $post for some reason.


Version: unspecified
Severity: normal

Details

Reference
bz72922

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 4:00 AM
bzimport set Reference to bz72922.
bzimport added a subscriber: Unknown Object (MLST).

Best guess is that state is being held inside the DeferredUpdates class between tests. For now the thanks test runs DeferredUpdates::clearPendingUpdates() via its setUp method and everything works. I wonder if MediaWikiTestCase::setUp() should be clearing DeferredUpdates instead?

Change 170819 had a related patch set uploaded by EBernhardson:
Clear DeferredUpdates state via setUp()

https://gerrit.wikimedia.org/r/170819

Change 170819 merged by jenkins-bot:
Clear DeferredUpdates state via setUp()

https://gerrit.wikimedia.org/r/170819

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:32 AM