Page MenuHomePhabricator
Create Task
Maniphest T74922

reset called on null in getCreatorsFromPostIDs because post not found, in Thanks tests
Closed, ResolvedPublic
Actions

Description

This is breaking Thanks tests: https://integration.wikimedia.org/ci/job/mwext-Thanks-testextension/24/consoleFull

$storage->find above it is apparently not finding the $post for some reason.

Version: unspecified
Severity: normal

Details

Reference
bz72922

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 4:00 AM
• bzimport added a project: StructuredDiscussions.
• bzimport set Reference to bz72922.
• bzimport added a subscriber: Unknown Object (MLST).
• Mattflaschen-WMF created this task.Nov 3 2014, 9:00 PM
EBernhardson added a comment.Nov 3 2014, 9:39 PM

Best guess is that state is being held inside the DeferredUpdates class between tests. For now the thanks test runs DeferredUpdates::clearPendingUpdates() via its setUp method and everything works. I wonder if MediaWikiTestCase::setUp() should be clearing DeferredUpdates instead?

gerritbot added a comment.Nov 3 2014, 9:42 PM

Change 170819 had a related patch set uploaded by EBernhardson:
Clear DeferredUpdates state via setUp()

https://gerrit.wikimedia.org/r/170819

gerritbot added a comment.Nov 4 2014, 8:39 AM

Change 170819 merged by jenkins-bot:
Clear DeferredUpdates state via setUp()

https://gerrit.wikimedia.org/r/170819

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits