Page MenuHomePhabricator

Don't remove non-breaking spaces before percent in Spanish
Closed, ResolvedPublic

Description

The Spanish style guidelines (https://es.wikipedia.org/wiki/Wikipedia:Manual_de_estilo#Espacios_duros) now recommends to include a non-breaking space before the percent symbol, but this script removes it.

This part of the script (method removeNonBreakingSpaceBeforePercent) should not be executed if the config lang is Spanish (es).

Besides, the help comment in "core" branch is wrong, because it says "Insert a non-breaking space between number and percent sign.", when the method does the opposite.


Version: unspecified
Severity: normal

Details

Reference
bz72941

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:44 AM
bzimport set Reference to bz72941.
bzimport added a subscriber: Unknown Object (????).

Is there some special need? MediaWiki adds this nbsp directly to html code of page..

OK, I understand now. Please, could you give a link so I can report it to the Spanish style guidlines?

Anyway, the second part of the bug is still valid, because the help comment of the method is wrong.

jayvdb claimed this task.

The MediaWiki commit which added the functionality is https://www.mediawiki.org/wiki/Special:Code/MediaWiki/23415 . It is included in the 1.11 release notes ( https://www.mediawiki.org/wiki/Release_notes/1.11 ) and the new phabricator task for it is T12334

The help comment was updated in pywikibot core.
http://git.wikimedia.org/commit/pywikibot%2Fcore.git/d2cef2457eed5766e585ff3dba4ba968b4275252

It was my fault that message was added incorrectly in October
http://git.wikimedia.org/blobdiff/pywikibot%2Fcore.git/9f99594616c0cb67eb4cdf80675974ae7efb5e7e/scripts%2Fcosmetic_changes.py ; thanks for reporting that bug so it was quickly fixed!