Page MenuHomePhabricator

[Suggestion] Detect bold in headings
Closed, ResolvedPublicBUG REPORT

Description

This task involves the work of introducing a new edit suggestion within the VisualEditor Suggestion Mode that makes people aware when heading levels are "bolded"

Deployment plan

#TODO

Meta

Requirements

Meta

  • Default configuration
    • maximumEditcount:
    • minimumEditcount:
    • Type: Suggestion
  • Detection heuristic: a heading, of any level, is wrapped in '''

User experience

  • Card design
    • Title: #TODO
    • Description (≤2 sentences): #TODO
    • Calls to action
      • Button name: #TODO
      • Button name: #TODO
  • Success toast: #TODO

Instrumentation
As with all Edit Checks and Suggestions, we will want to know:

  • Any time a Suggestion of this type is activated within an edit session
  • Any time someone views a Suggestion of this type within an edit session
  • Any time someone engages with a Suggestion and how they engage with it

Original ticket description

Environment- beta

1> insert a table
2> click on the Header cell.
3> Now select Annotations sub menu.
4> Bold is shown as one of the style elements.

Text typed in a header cell is already bold. So, activating/deactivating it from the sub menu list doesn't change anything.


Version: unspecified
Severity: trivial
OS: Windows XP

Details

Reference
bz72949
Related Changes in Gerrit:

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 3:45 AM
bzimport set Reference to bz72949.

This depends on a particular visual concepts, and I'm not sure it makes sense. What are others' thoughts?

We already have this issue with headings. The text is not actually annotated as bold and they would produce different wikitext (==Bold== vs =='''Bold'''==). Depending on local CSS wikitable headers / H2 tags may not even be render as bold by default, so I think semantically they're different but with our WYSIWYG editor, there's no visual cue for 'double bold'.

(In reply to Ed Sanders from comment #2)

but with our WYSIWYG editor, there's no visual cue for 'double bold'.

CSS has that concept, but few browsers and fonts support it. There are reports of users seeing "double bold" on VPT from time to time and getting confused.

Jdforrester-WMF renamed this task from VisualEditor: Annotations can conflict with local CSS rules, e.g. bold text in headings to Annotations can conflict with local CSS rules, e.g. bold text in headings.Nov 24 2014, 12:29 AM
Jdforrester-WMF set Security to None.
Aklapper changed the subtype of this task from "Task" to "Bug Report".Feb 5 2022, 2:33 PM
Aklapper removed subscribers: rmoen, TrevorParscal.

This might be a suitable candidate for an edit check (T265163).

ppelberg renamed this task from Annotations can conflict with local CSS rules, e.g. bold text in headings to [Suggestion] Detect bold in headings.Dec 23 2025, 6:18 AM
ppelberg updated the task description. (Show Details)
ppelberg subscribed.

This might be a suitable candidate for an edit check (T265163).

Good spot, Ed. I've updated the task description to act on this idea.

Change #1235104 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Experimental DoubleBoldEditCheck

https://gerrit.wikimedia.org/r/1235104

Detection heuristic: a heading, of any level, is wrapped in '''

The check as implemented checks for bold inside any of the following bold-by-default contexts:

  • Heading levels of h3 ("Sub-heading 1") or higher (h4, h5, ). nb h2 and h1 are not bold by default
  • Definiton terms in a definition list
  • Table headings

It's sort of the inverse of T413124, and I think we might need to make sure that the two are consistent in how they talk about things -- that one is "I noticed you had a non-heading that's entirely-bolded, should it really be a heading?"

Change #1235104 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Experimental DoubleBoldEditCheck

https://gerrit.wikimedia.org/r/1235104

Detection heuristic: a heading, of any level, is wrapped in '''

The check as implemented checks for bold inside any of the following bold-by-default contexts:

  • Heading levels of h3 ("Sub-heading 1") or higher (h4, h5, ). nb h2 and h1 are not bold by default
  • Definiton terms in a definition list
  • Table headings

The check seems to be working correctly for these scenarios.

However, there is something that need some clarification on:

When a real heading of "Heading" (or any format) is bolded, it is showing "Use real headings" check. Isn't it a real heading..and not a text that was bolded in an attempt to create a heading ? When I click on "Adjust heading" it seems to be unnecessarily adjusts it to sub-heading 1 format.

Screenshot 2026-02-10 at 12.43.10 PM.png (2,818×1,072 px, 396 KB)

Screenshot 2026-02-10 at 12.43.25 PM.png (2,832×1,104 px, 404 KB)

Isn't it a real heading..and not a text that was bolded in an attempt to create a heading ?

Yes - that's a bug in a different check, FakeHeadingsEditCheck, which will be fixed in this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1239108

ppelberg raised the priority of this task from Lowest to Medium.Feb 18 2026, 6:31 PM