Page MenuHomePhabricator

The WikiEditor dialogs do not work in Page namespace
Closed, ResolvedPublic

Description

Details

Reference
bz72960

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:45 AM
bzimport added a project: ProofreadPage.
bzimport set Reference to bz72960.
bzimport added a subscriber: Unknown Object (MLST).
Tpt created this task.Nov 4 2014, 6:47 PM

I am not sure what I'm supposed to see after which steps and how to compare. :(

I am not sure what I'm supposed to see after which steps and how to compare. :(

On any page of Proofread's "Page" namespace, WikiEditor dialogs wouldn't work (dialogs for adding Links, Image, Ref, Table, Gallery as well Search/Replace dialog) that was also affecting User scripts which relied on that class, such as RefBar or SAETools (with later on, it was impossible even to preview changes before saving them).

I've sent workaround patch, created by User:HrantKhachatrian which was accepted, but is not yet released to Wikisources.

Core cause of this issue comes from this change, and I think it's best to solve it at core level. As I don't know enough about CONTENT_MODELS, I'd ask Tpt and WikiEditor maintainers to look at this, and WikiEditor to behave regularly on Page namespace, as it was before above mentioned July change.

Xelgen set Security to None.Nov 25 2014, 10:18 AM
Xelgen added subscribers: TheDJ, Catrope.
GOIII added a subscriber: GOIII.Nov 27 2014, 8:03 AM

I've sent workaround patch, created by User:HrantKhachatrian which was accepted, but is not yet released to Wikisources.

That would be https://gerrit.wikimedia.org/r/174936 in case it matters.

Fwiw... dialogs seem to be working for the Page: namespace on test2 at least. see https://test2.wikipedia.org/s/b54

The built-in search & replace still doesn't work under IE(11) however. Pretty sure the IE release at the time (IE8?) wasn't working with the S&R dialog and it was excluded in the scripts (pretty much forgotten about since). Then again it could just be me & setup that's preventing it from loading somehow.

GOIII added a comment.Dec 3 2014, 8:19 AM

Working again with the roll-out of 1.25wmf10

GOIII closed this task as Resolved.Dec 3 2014, 8:19 AM
GOIII triaged this task as Medium priority.
GOIII moved this task from Backlog to Done on the ProofreadPage board.Jun 12 2016, 3:58 AM