Page MenuHomePhabricator

Pass a MediaWiki title validator to TitleInputWidgets#validate function by default(?)
Open, MediumPublic

Description

Should we style TitleInputWidgets with invalid contents with a red border (or whatever), like we do in some other places?

Details

Reference
bz72970

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:46 AM
bzimport set Reference to bz72970.

(In reply to Roan Kattouw from comment #0)

Should we style MWTitleInputWidgets with invalid contents with a red border,
like we do in some other places?

Yes. Maybe we should have an -invalid flag in OOUI… Leaving in VE for now.

Jdforrester-WMF renamed this task from VisualEditor: Style invalid MWTitleInputWidgets to Style invalid TitleInputWidgets.Jul 3 2015, 3:59 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF set Security to None.

As part of T72957, a month before this task was filed, we implemented this for OOUI's TextInputWidget (and thus MediaWiki's TitleInputWidget); you just need to pass in a validate function or regex in the constructor, or call setValidation later as needed.

Given that, re-titling to be more useful.

Jdforrester-WMF renamed this task from Style invalid TitleInputWidgets to Pass a MediaWiki title validator to TitleInputWidgets#validate function by default(?).Oct 20 2017, 7:14 PM
SBisson added a subscriber: SBisson.

Feel free to close if this is not relevant anymore.