Page MenuHomePhabricator

JavaScript not working in Firefox on topic page
Closed, ResolvedPublic

Description

On topic pages like http://en.wikipedia.beta.wmflabs.org/wiki/Topic:S3ufwcms95i0atkw , Flow JavaScript is not loaded.

So instead of an expandable reply box at the bottom, you get a Reply link, etc.


Version: unspecified
Severity: normal

Details

Reference
bz72994

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:48 AM
bzimport set Reference to bz72994.

It's because it still has ext.flow.new in the body (and not the right module either).

This should fix itself on November 22, 30 days after https://gerrit.wikimedia.org/r/#/c/165756/ was merged (which dropped the new level).

Should we maintain a dummy ext.flow.new that depends on ext.flow for the next month so this doesn't effect users?

Yeah, I'll do that.

Although now it seems to not be reproducible for me due to some vagary.

Also, is hard-refreshing supposed to fix this in general (module name changes)?

The headers indicate the response comes direct from varnish:

Age:2074998
X-Varnish:279882283, 1118282702 1116027078

I have not looked into ops config, but i wouldn't expect a hard refresh to override varnish.

Yeah, that's probably right. An action=purge might, though, but we can't rely on that either.

Change 171163 had a related patch set uploaded by Mattflaschen:
Add temporary ext.flow.new module to avoid missing JS

https://gerrit.wikimedia.org/r/171163

Change 171163 merged by jenkins-bot:
Add temporary ext.flow.new module to avoid missing JS

https://gerrit.wikimedia.org/r/171163

Change 171173 had a related patch set uploaded by EBernhardson:
Add temporary ext.flow.new module to avoid missing JS

https://gerrit.wikimedia.org/r/171173

Change 171173 merged by jenkins-bot:
Add temporary ext.flow.new module to avoid missing JS

https://gerrit.wikimedia.org/r/171173

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:32 AM