Page MenuHomePhabricator

welcome -quick fails
Closed, ResolvedPublic

Description

In addition to the errors in bug 73017 (T75017), welcome has two other serious coding issues

E:722,20: Class 'User' has no 'getall' member (no-member)
E:725,25: Instance of 'WelcomeBot' has no '_parseNewUserLogOld' member (no-member)

It is in a branch of code that needs the -quick parameter to be invoked, and looks like it is trying to

  1. preload the pages, and
  2. fallback to an implementation which wasnt ported.

Details

Reference
bz73019
Related Changes in Gerrit:

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:49 AM
bzimport set Reference to bz73019.
bzimport added a subscriber: Unknown Object (????).
jayvdb set Security to None.
jayvdb removed a subscriber: Unknown Object (????).

The pylint entry for _parseNewUserLogOld appears to have voodoo disappeared, so that can be ignored.

In compat, the User class does not have a member getall. The compat source code uses "userlib.getall" (a module function), which was incorrectly converted/ported into an instance method.

http://git.wikimedia.org/blob/pywikibot%2Fcompat.git/64f6f0671646506863b65826a5941066ed90f775/userlib.py#L603

The equivalent core functionality is Site.preloadpages, however that doesnt load user info . Core does not have a preloadusers method.

jayvdb renamed this task from welcome using missing functions to welcome -quick fails.Nov 29 2014, 6:37 AM
jayvdb triaged this task as Medium priority.
jayvdb raised the priority of this task from Medium to High.Jan 7 2016, 8:37 PM
jayvdb updated the task description. (Show Details)

Change 269945 had a related patch set uploaded (by Xqt):
[bugfix] Deprecate -quick option

https://gerrit.wikimedia.org/r/269945

Change 269945 merged by jenkins-bot:
[bugfix] Deprecate -quick option

https://gerrit.wikimedia.org/r/269945