Page MenuHomePhabricator
Create Task
Maniphest T75020

[Task] Move JS and PHP view code to separate repo
Closed, ResolvedPublic
Actions

Description

This should include templates, everything using wfTemplate and all jquery.wikibase widgets from lib/.

Content

Messages

  • wikibase-add
  • wikibase-add-badges
  • wikibase-addqualifier
  • wikibase-addreference
  • wikibase-alias-edit-placeholder
  • wikibase-aliases-empty
  • wikibase-aliases-input-help-message
  • wikibase-aliases-label
  • wikibase-badgeselector-badge-placeholder-title
  • wikibase-cancel
  • wikibase-claimview-snak-new-tooltip
  • wikibase-claimview-snak-tooltip
  • wikibase-description-edit-placeholder-language-aware (used in WikibaseRepo)
  • wikibase-description-empty
  • wikibase-description-input-help-message
  • wikibase-edit
  • wikibase-entityselector-more
  • wikibase-fingerprintgroupview-input-help-message
  • wikibase-fingerprintview-input-help-message
  • wikibase-label-edit-placeholder-language-aware (used in WikibaseRepo)
  • wikibase-label-empty
  • wikibase-label-input-help-message
  • wikibase-move-*
  • wikibase-property-footer
  • wikibase-propertypage-datatype
  • wikibase-remove
  • wikibase-remove-inprogress
  • wikibase-save (used in WikibaseRepo)
  • wikibase-save-inprogress
  • wikibase-sitelink-page-edit-placeholder
  • wikibase-sitelink-site-edit-placeholder
  • wikibase-sitelinkgroupview-input-help-message
  • wikibase-sitelinks-*
  • wikibase-sitelinks-input-help-message
  • wikibase-snakformat-invalid-value (used in WikibaseRepo)
  • wikibase-snakformat-propertynotfound
  • wikibase-snakview-choosesnaktype
  • wikibase-snakview-property-input-placeholder
  • wikibase-snakview-variation-datavaluetypemismatch
  • wikibase-snakview-variation-datavaluetypemismatch-details
  • wikibase-snakview-variation-nonewvaluefordeletedproperty
  • wikibase-snakview-variations-novalue-label
  • wikibase-snakview-variations-somevalue-label
  • wikibase-statements
  • wikibase-statementview-rank-deprecated
  • wikibase-statementview-rank-normal
  • wikibase-statementview-rank-preferred
  • wikibase-statementview-referencesheading-pendingcountersubject
  • wikibase-terms
  • wikibase-ui-pendingquantitycounter-nonpending
  • wikibase-ui-pendingquantitycounter-pending
  • wikibase-ui-pendingquantitycounter-pending-pendingsubpart

Dependencies

Messages

  • pagetitle (in core)
  • parentheses (in core, used in WikibaseClient as well)
  • toc (in core)
  • wikibase-deletedentity- (in WikibaseLib)
  • wikibase-sitelinks-sitename-* (not wikibase-sitelinks-sitename-columnheading, that's used in WikibaseClient) (in WikibaseLib)
  • wikibase-snakview-snaktypeselector-* (in WikibaseLib)
  • word-separator

Details

Reference
bz73020

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedAddshoreT173818 [Epic] Kill the Wikidata build step
 ResolvedAddshoreT181709 Cleanup Phabricator tickets once the build is dead
 InvalidNoneT108946 [Epic] Improve the development infrastructure
DeclinedNoneT74907 [Task] move git repositories that are dependencies of wikidata to gerrit
 ResolvedTobi_WMDE_SWT103697 Add Phabricator project tag for Wikibase-DataModel-Services
 ResolvedAddshoreT45855 [Task] UI messages in repo, JS is in lib
 DeclinedNoneT75863 [Task] Split wikibase.git
 OpenNoneT108296 [Epic] Remove WikibaseLib
 ResolvedJeroenDeDauwT108286 [Task] Move Wikibase Lib code that belongs in DataModel Services to this new component
 ResolvedJeroenDeDauwT108963 [Task] Use services from WikibaseDataModelServices added in 1.1.0 release
 ResolvedAddshoreT75020 [Task] Move JS and PHP view code to separate repo
 DeclinedTobi_WMDE_SWT68417 Move repo-specific JS code from lib to repo
 Resolved• adrianheineT87432 Identify messages that belong to WikibaseView
 Resolved• adrianheineT87433 Split wikibase.utilities into WikibaseView and lib part
 Resolved• adrianheineT87434 Split entityViewInit into WikibaseRepo and WikibaseView part
 Duplicate• adrianheineT90720 Introduce wikibase.view.ViewFactory
 Resolved• adrianheineT87435 Remove reference to wbEntityId from WikibaseView
 Resolved• adrianheineT93745 Move view related code into separate directory
 ResolvedLydia_PintscherT130316 Remove dependency from WikibaseView on StatementRankSerializer in WikibaseRepo
 DeclinedNoneT130323 Remove dependency from WikibaseView on SnakFormatter in WikibaseLib
 InvalidNoneT130342 Remove dependency from WikibaseView on jquery.wikibase.tooltip in WikibaseLib
 InvalidNoneT130343 Remove dependency from WikibaseView on wikibase.sites in WikibaseLib and Site(|List|Store) in MediaWiki
 InvalidNoneT130344 Remove dependency from WikibaseView on mw.config.values.wbRepo in WikibaseLib
 Resolved• adrianheineT130345 Remove dependency from WikibaseView on UserLanguageLookup in WikibaseLib
 InvalidNoneT130346 Remove dependency from WikibaseView on language classes in WikibaseLib
 InvalidNoneT75887 [Task] Find a home for shared utilities like reporters, sites, etc.
 InvalidNoneT75875 Find a home for EntityChange and friends
 DeclinedNoneT76469 move formatters into own directory
 ResolvedthiemowmdeT76468 move parsers and validators into own directory
 ResolvedAddshoreT104187 Move services in DataModel to DataModel Services
 ResolvedJanZerebeckiT102629 Request Gerrit repository for WikibaseDataModelServices
 ResolvedJeroenDeDauwT93741 [RFC] Create place to put common Wikibase services
 ResolvedAddshoreT110344 Fix cohesion/CRP issue in Wikibase DataModel Services
 DeclinedNoneT108681 [RFC] Create a new Wikibase-Change-Services component
 InvalidNoneT108835 [RFC] Find a new home for Wikibase Lib / Reporting

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:49 AM
• bzimport added a project: MediaWiki-extensions-Wikibase-Repo.
• bzimport set Reference to bz73020.
• bzimport added a subscriber: Unknown Object (MLST).
• adrianheine created this task.Nov 5 2014, 2:48 PM
Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:37 PM
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
• adrianheine added a comment.Dec 16 2014, 1:41 PM

After all my pending changes are merged in, the PHP part of the (potential) repository looks like this:

Content:

  • Wikibase\Repo\View\*
  • wfTemplate
  • repo/tests/phpunit/includes/View/*

Dependencies:

  • wikibase/data-model
    • Wikibase\DataModel\*
  • data-values/data-types
    • DataTypes\DataType (PropertyView)
  • data-values/data-values
    • DataValues\StringValue
  • data-values/interfaces
    • ValueFormatters\FormatterOptions (EntityViewFactory)
    • ValueFormatters\FormattingException (SnakHtmlGenerator)
    • ValueFormatters\ValueFormatter (EntityViewFactory)
  • »WikibaseLibInterfaces«
    • Wikibase\Lib\EntityIdFormatter
    • Wikibase\Lib\EntityIdFormatterFactory
    • Wikibase\Lib\SnakFormatter (EntityViewFactory, SnakHtmlGenerator)
    • Wikibase\Lib\Store\EntityLookup (EntityViewFactory, SiteLinksView)
    • Wikibase\Lib\Store\EntityRevisionLookup (EntityViewPlaceholderExpander)
    • Wikibase\Lib\Store\LabelLookup
    • Wikibase\Lib\Store\StorageException (EntityViewPlaceholderExpander)
  • Bogus
    • Wikibase\EntityRevision (EntityView, PropertyView, ItemView)
    • Wikibase\LanguageFallbackChain (EntityViewFactory)
    • Wikibase\Lib\OutputFormatSnakFormatterFactory (EntityViewFactory)
    • Wikibase\Lib\Serializers\ClaimSerializer (ClaimHtmlGenerator)
    • Wikibase\UserLanguageLookup (EntityViewPlaceholderExpander)
    • Wikibase\Utils (SiteLinksView, TermBoxView)
  • mediawiki/core
    • Html (EntityView)
    • Message (SectionEditLinkGenerator, SiteLinksView, TermBoxView)
    • MessageCache
    • Language (EntityViewFactory, EntityView, TermBoxView, EntityViewPlaceholderExpander)
    • MediaWikiLangTestCase
    • MediaWikiSite
    • MediaWikiTestCase
    • MWException (EntityViewPlaceholderExpander)
    • Sanitizer (SiteLinksView)
    • Site (SiteLinksView)
    • SiteList (SiteLinksView)
    • SpecialPageFactory (SectionEditLinkGenerator)
    • Title (TermBoxView, EntityViewPlaceholderExpander)
    • User (EntityViewPlaceholderExpander)
    • wfMessage
    • wfProfileIn
    • wfProfileOut
    • wfWarn
    • wfUrlencode
    • wfRandom
• adrianheine added a comment.Dec 16 2014, 2:04 PM

I forgot Wikibase\Template and Wikibase\TemplateRegistry. Also, Wikibase\Lib\EntityIdFormatter is probably bogus, since it's not an interface.

• adrianheine added a comment.Dec 17 2014, 10:25 AM

https://gerrit.wikimedia.org/r/#/c/180431/ makes EntityIdFormatter an interface, so it's not bogus anymore.

• adrianheine added a comment.Dec 17 2014, 12:33 PM

https://gerrit.wikimedia.org/r/180450 extracts UserLanguageLookup interface. With that, View does not depend on Repo anymore.

Tobi_WMDE_SW added a comment.Jan 8 2015, 3:04 PM

@adrianheine what are the outstanding pending changes to move forward here and can you link them please?

Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-01-08§.Jan 8 2015, 3:05 PM
Tobi_WMDE_SW set Security to None.
Tobi_WMDE_SW moved this task from Backlog to Review on the Wikidata-Sprint-2015-01-08§ board.Jan 8 2015, 3:45 PM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Jan 8 2015, 10:26 PM
• adrianheine added a comment.Jan 13 2015, 10:22 AM

https://gerrit.wikimedia.org/r/#/c/180431/ and https://gerrit.wikimedia.org/r/#/c/180450/. After that, Wikibase\Repo\View should not depend on WikibaseRepo anymore.

There are still some bad dependencies to WikibaseLib (definitely: Wikibase\Lib\OutputFormatSnakFormatterFactory, Wikibase\Lib\Serializers\ClaimSerializer, maybe: Wikibase\EntityRevision, Wikibase\LanguageFallbackChain, Wikibase\Utils), though.

Tobi_WMDE_SW added a comment.Jan 20 2015, 9:17 AM

https://gerrit.wikimedia.org/r/#/c/180431/ merged.
https://gerrit.wikimedia.org/r/#/c/180450/ still in review.

• adrianheine mentioned this in T45855: [Task] UI messages in repo, JS is in lib.Jan 21 2015, 11:04 AM
• adrianheine added a project: Tracking-Neverending.Jan 21 2015, 3:13 PM
• adrianheine added a comment.Jan 21 2015, 3:26 PM

I'll probably need to create subtasks for the following (unless they are trivial):

  • Move Wikibase\Repo\View to Wikibase\View
  • Identify contents
    • Identify JS files that will belong to WikibaseView
    • Identify PHP files that will belong to WikibaseView
    • Identify messages
  • Create base files
    • composer.json
    • WikibaseView.php
    • …
  • Put files in new repository
  • Add CI jobs
  • Remove files from Wikibase.git and add dependency
• adrianheine added a comment.Jan 23 2015, 12:37 PM

Additional subtask I need to create (and do): Move messages between lib and repo (messages used in lib need to be moved to lib, messages used in repo need to be moved to WikibaseView)

• adrianheine added a subscriber: JeroenDeDauw.Jan 27 2015, 8:58 AM

@JeroenDeDauw pointed out several things:

  • It's quite suspicious to depend on factories (OutputFormatSnakFormatterFactory, EntityIdFormatterFactory); it's better to use own (formatting) interfaces WikibaseRepo can then implement based on its factories
  • EntityIdFormatter could probably move to datamodel
• adrianheine updated the task description. (Show Details)Jan 28 2015, 9:30 AM
• adrianheine mentioned this in T87432: Identify messages that belong to WikibaseView.
• adrianheine closed subtask T87432: Identify messages that belong to WikibaseView as Resolved.
• adrianheine updated the task description. (Show Details)Jan 29 2015, 8:23 AM
• adrianheine closed subtask T87433: Split wikibase.utilities into WikibaseView and lib part as Resolved.Feb 3 2015, 8:46 AM
• adrianheine closed subtask T87435: Remove reference to wbEntityId from WikibaseView as Resolved.Feb 10 2015, 1:32 PM
Tobi_WMDE_SW closed subtask T87434: Split entityViewInit into WikibaseRepo and WikibaseView part as Resolved.Mar 13 2015, 11:27 AM
Tobi_WMDE_SW closed subtask T68417: Move repo-specific JS code from lib to repo as Declined.Mar 24 2015, 2:03 PM
Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-03-24.Mar 24 2015, 2:06 PM
Tobi_WMDE_SW removed a project: § Wikidata-Sprint-2015-03-24.
Tobi_WMDE_SW closed subtask T93745: Move view related code into separate directory as Resolved.Apr 1 2015, 2:59 PM
JeroenDeDauw added a subscriber: • Jonas.Aug 6 2015, 5:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2015, 5:05 AM
JeroenDeDauw added a parent task: T108296: [Epic] Remove WikibaseLib.Aug 7 2015, 9:00 AM
Ricordisamoa subscribed.Aug 8 2015, 11:19 PM
JanZerebecki renamed this task from Move JS and PHP view code to separate repo to [Task] Move JS and PHP view code to separate repo.Sep 10 2015, 3:32 PM
JanZerebecki added a parent task: T45855: [Task] UI messages in repo, JS is in lib.
JanZerebecki added a project: MediaWiki-extensions-WikibaseView.Sep 10 2015, 3:46 PM
JanZerebecki subscribed.Sep 10 2015, 3:49 PM

The project is named MediaWiki-extensions-WikibaseView, but it should become a component that does not depend on Mediawiki, right?

Then we should rename the project.

• adrianheine added a comment.Sep 11 2015, 7:30 AM

Even if some component does not depend on MediaWiki, I'd still consider it a MediaWiki extension if it optionally provides MediaWiki integration. Currently, all our resource loading happens through ResourceLoader, and that won't change soon.

• adrianheine mentioned this in T112120: [Task] Move ValueView repository from github to gerrit.Sep 16 2015, 7:30 AM
JanZerebecki added a parent task: T75863: [Task] Split wikibase.git.Jan 6 2016, 11:38 PM
Bene subscribed.Feb 23 2016, 10:17 AM
Bene moved this task from ready to go to consider for next sprint on the Wikidata board.Feb 29 2016, 10:51 AM
• adrianheine created subtask T130316: Remove dependency from WikibaseView on StatementRankSerializer in WikibaseRepo.Mar 17 2016, 9:50 PM
• adrianheine created subtask T130323: Remove dependency from WikibaseView on SnakFormatter in WikibaseLib.Mar 17 2016, 10:22 PM
• adrianheine created subtask T130342: Remove dependency from WikibaseView on jquery.wikibase.tooltip in WikibaseLib.Mar 18 2016, 7:33 AM
• adrianheine created subtask T130343: Remove dependency from WikibaseView on wikibase.sites in WikibaseLib and Site(|List|Store) in MediaWiki.Mar 18 2016, 7:36 AM
• adrianheine created subtask T130344: Remove dependency from WikibaseView on mw.config.values.wbRepo in WikibaseLib.Mar 18 2016, 7:40 AM
• adrianheine created subtask T130345: Remove dependency from WikibaseView on UserLanguageLookup in WikibaseLib.
• adrianheine created subtask T130346: Remove dependency from WikibaseView on language classes in WikibaseLib.Mar 18 2016, 7:45 AM
Lydia_Pintscher closed subtask T130316: Remove dependency from WikibaseView on StatementRankSerializer in WikibaseRepo as Resolved.Apr 3 2016, 12:46 PM
• adrianheine mentioned this in T132548: [Story] Make WikibaseView independent of MediaWiki.Apr 13 2016, 8:24 AM
• adrianheine closed subtask T130345: Remove dependency from WikibaseView on UserLanguageLookup in WikibaseLib as Resolved.Apr 19 2016, 9:12 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 9:12 PM
Danny_B renamed this task from [Task] Move JS and PHP view code to separate repo to [Task] Move JS and PHP view code to separate repo (tracking).May 27 2016, 5:59 PM
• adrianheine renamed this task from [Task] Move JS and PHP view code to separate repo (tracking) to [Task] Move JS and PHP view code to separate repo.May 30 2016, 7:49 AM

There is nothing tracking about this task. It's just a big task, but it's a clearly defined one which requires to do one thing and one thing only to be finished. It just has a lot of prerequisites.

Danny_B moved this task from Tag to Should be Goal instead on the Tracking-Neverending board.Jul 30 2016, 10:14 PM
• Phabricator_maintenance added a project: Goal.Aug 13 2016, 8:41 PM
• Phabricator_maintenance removed a project: Tracking-Neverending.Aug 13 2016, 9:57 PM
Lydia_Pintscher moved this task from consider for next sprint to ready to go on the Wikidata board.Oct 17 2016, 2:45 PM
Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 26 2017, 11:42 PM
Krinkle mentioned this in T189538: Reduce complexity of Wikibase JS module registration.Mar 12 2018, 10:53 PM
Addshore closed this task as Resolved.Jul 12 2018, 3:19 PM
Addshore claimed this task.
Addshore subscribed.

The code is now all split up in different git repos included as submodules, and can also be found as npm packages.
https://github.com/wikimedia/mediawiki-extensions-Wikibase/tree/2454496a7210a34b57bf06679efcffc957808a34/view/lib

Restricted Application added a project: User-Addshore. · View Herald TranscriptJul 12 2018, 3:19 PM
Addshore moved this task from Unsorted 💣 to Closing ✔️ on the User-Addshore board.Jul 16 2018, 7:11 AM
Lydia_Pintscher closed subtask T130342: Remove dependency from WikibaseView on jquery.wikibase.tooltip in WikibaseLib as Invalid.Mar 21 2025, 1:09 PM
Lydia_Pintscher closed subtask T130344: Remove dependency from WikibaseView on mw.config.values.wbRepo in WikibaseLib as Invalid.
Lydia_Pintscher closed subtask T130343: Remove dependency from WikibaseView on wikibase.sites in WikibaseLib and Site(|List|Store) in MediaWiki as Invalid.
Lydia_Pintscher closed subtask T130346: Remove dependency from WikibaseView on language classes in WikibaseLib as Invalid.
Lydia_Pintscher closed subtask T130323: Remove dependency from WikibaseView on SnakFormatter in WikibaseLib as Declined.Mar 21 2025, 4:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits