Page MenuHomePhabricator

Special:Version generates the wrong closing tag </td> for the tag <tr>
Closed, ResolvedPublic

Description

[[Special:Version]] generates

<tr></td></td></td>

instead of

<tr></td></td></tr>

Patch: (Sorry https://tools.wmflabs.org/gerrit-patch-uploader/ does not work)

diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php
index 6b9173f..f491c77 100644

  • a/includes/specials/SpecialVersion.php

+++ b/includes/specials/SpecialVersion.php
@@ -808,7 +808,7 @@ class SpecialVersion extends SpecialPage {

		$html .= Html::rawElement( 'td', array( 'class' => 'mw-version-ext-description' ), $description );
		$html .= Html::rawElement( 'td', array( 'class' => 'mw-version-ext-authors' ), $authors );
  • $html .= Html::closeElement( 'td' );

+ $html .= Html::closeElement( 'tr' );

		return $html;
	}

Version: unspecified
Severity: trivial

Details

Reference
bz73081

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:53 AM
bzimport set Reference to bz73081.

Change 171533 had a related patch set uploaded by Gerrit Patch Uploader:
Fix wrong closing tag

https://gerrit.wikimedia.org/r/171533

Change 171533 merged by jenkins-bot:
Fix wrong closing tag in Special:Version

https://gerrit.wikimedia.org/r/171533