Page MenuHomePhabricator

Skip images when required attribution is impossible
Open, HighPublic


From the example in bug 73125:
6.2 Images
• File:BathsOfCaracalla.jpg Source: License: CC-BY-SA-
3.0 Contributors: ? Original artist: ?
• File:DomusAurea.jpg Source: License: Public domain Contrib-
utors: ? Original artist: ?

So in the first case we know that attribution is required (BY) and that we're not giving it, but we include the image nonetheless. We should instead skip it (optionally leaving some placeholder/note).

In short: when you'd display "Contributors: ? Original artist: ?" in the PDF, and the file is not PD (as marked by [[ | AttributionRequired ]]), skip the file.

Version: unspecified
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:56 AM
bzimport added a project: Collection.
bzimport set Reference to bz73130.
bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis triaged this task as High priority.Apr 6 2015, 1:18 PM
Nemo_bis set Security to None.
Restricted Application added a subscriber: Matanya. · View Herald Transcript

We should get a boolean from the imageinfo API for this. "Includable" or "licensed" or something like that. Certainly OCG shouldn't be trying to parse license fields itself.

Certainly OCG shouldn't be trying to parse license fields itself.

What is generating the "?" then?

@Nemo_bis: we're just repeating the data provided by the extmetadata property of the action API imageinfo query:

We can grab AttributionRequired as well, but it would be nicer if extmetadata would also give us a boolean for AttributeValid rather than making us try to match against ?. After all -- is that ? localized? What character is returned in arabic locales?

? does not come from any internal logic in CommonsMetadata - if the author or source is not specified, the relevant key will simply be missing from the response:

The required logic is: AttributionRequired is true(-ish - T86726) but Artist and Attribution are both missing. (This assumes you are using the Attribution field, which did not exist at the time the above patch was made against OCG.) I can put this logic into CMD if you prefer that.

Change 218950 had a related patch set uploaded (by Cscott):
Add "AttributionRequired" metadata to OCG bundle.

Change 218950 merged by jenkins-bot:
Add "AttributionRequired" metadata to OCG bundle.

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Though this task might be do-able once SDC is in production, it's not an SDC task itself.