Page MenuHomePhabricator

VisualEditor: "Insert table" tool in a separate menu to the other table tools (delete/merge/caption)
Closed, ResolvedPublic1 Estimated Story Points

Description

VisualEditor: "Insert table" tool should be (also?) in the "Table" menu, not (or in addition to?) "Insert" menu. I was quite confused for a moment by the table icon being grayed out, and I've been told I'm not the only one.

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:45 AM
bzimport set Reference to bz73212.

+1. When user wants to create a new table, he can see the icon in the toolbar, but it's marked as displayed. Really confusing. Imho, if we have a special menu for tables, "Insert table" should be placed there instead of being in "Insert menu". The current solution is reasonable, but unintuitive. (Maybe "Insert table" could be visible alternatively with "Delete table" #brainstorm).

The current option is highly temporary, AFAIK.

Alternatively, we could put the table inspector in the proper place (i.e., on the table) rather than over-loading the toolbar, which would remove the confusion.

Jdforrester-WMF lowered the priority of this task from High to Medium.Jan 15 2015, 12:50 AM
Jdforrester-WMF set Security to None.

My client asked about this and I told her "That's how it is on Wikipedia" and found this bug (before I filed my own, yay!).

I vote for enabling the icon when not in a table to allow for table creation.

If I were really sick, I'd say that the option to insert a table should remain available even when in a table cell, so that we could do 90s style webpage layouts in the VisualEditor.

But I'm only a little sick, so activating it to enable table creation/insertion is what I'm going with.

Change 267532 had a related patch set uploaded (by Esanders):
Introduce table and table cell context

https://gerrit.wikimedia.org/r/267532

Esanders renamed this task from VisualEditor: "Insert table" tool should be (also?) in the "Table" menu, not (or in addition to?) "Insert" menu to VisualEditor: "Insert table" tool in a separate menu to the other table tools (delete/merge/caption).Jan 31 2016, 11:25 AM
Esanders updated the task description. (Show Details)

Change 267532 merged by jenkins-bot:
Introduce table and table cell context

https://gerrit.wikimedia.org/r/267532