Gallery with no images (invalid characters as gallery contents) creates an invisible node and can't be edited
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Swainr
	Nov 10 2014, 5:40 PM

Description

Gallery with no images (invalid characters as gallery contents) creates an invisible node and can't be edited.

For example, create a page with the following wikitext:

<gallery>
>>
</gallery>

Example: https://en.wikipedia.org/w/index.php?title=User:Matma_Rex/sandbox&oldid=826934821

This renders as an empty gallery (<ul class="gallery mw-gallery-traditional"></ul>).

In VE, it displays a placeholder, but it seems that it can't be clicked to focus it:

When focussed using arrow keys, it displays a completely mispositioned context menu:

Trying to use the "Edit" button causes a JS error in the console:

TypeError: Cannot read property 'toggleHighlighted' of undefined
    at VeUiMWGalleryDialog.ve.ui.MWGalleryDialog.onHighlightItem (https://en.wikipedia.org/w/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js?22058:591:7)
    at https://en.wikipedia.org/w/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js?22058:342:13
    at fire (https://en.wikipedia.org/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:3317:31)
    at Object.add [as done] (https://en.wikipedia.org/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:3376:7)
    at VeUiMWGalleryDialog.<anonymous> (https://en.wikipedia.org/w/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js?22058:341:9)
    at https://en.wikipedia.org/w/resources/lib/oojs-ui/oojs-ui-windows.js?f9a29:748:28
    at mightThrow (https://en.wikipedia.org/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:3583:29)
    at process (https://en.wikipedia.org/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:3651:12)

Details

Reference: bz73230

	Subject	Repo	Branch	Lines +/-
	ve.ce.MWGalleryNode: Ensure we always have a focusable element	mediawiki/extensions/VisualEditor	master	+2 -2
	ve.ui.MWGalleryDialog: Handle galleries with 0 items	mediawiki/extensions/VisualEditor	master	+14 -12

Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:46 AM

• bzimport added projects: Browser-Support-Google-Chrome, VisualEditor-EditingTools.

• bzimport set Reference to bz73230.

Swainr created this task.Nov 10 2014, 5:40 PM

Also found in FF 33.1.

Confirmed.

In addition to the scenario described abotve:

If ">>" is entered - the gallery will be saved as

</gallery>

If, say, "caption", will be surrounded with << and >>, then the inserted Gallery becomes invisible, but in Edit source it will be:

Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 4:30 PM

Etonkovidova triaged this task as Low priority.Feb 9 2015, 10:45 PM

Etonkovidova set Security to None.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Feb 11 2015, 5:25 PM

Danny_B added a project: Regression.May 8 2016, 2:11 PM

This is not reproducible as originally written, due to changes in the gallery inspector, but a similar issue is still present. I updated the description.

matmarex claimed this task.Feb 21 2018, 9:21 PM

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.

Change 413252 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWGalleryDialog: Handle galleries with 0 items

https://gerrit.wikimedia.org/r/413252

Change 413253 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ce.MWGalleryNode: Ensure we always have a focusable element

https://gerrit.wikimedia.org/r/413253

matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Feb 21 2018, 9:33 PM

Change 413252 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWGalleryDialog: Handle galleries with 0 items

https://gerrit.wikimedia.org/r/413252

Change 413253 merged by Jforrester:
[mediawiki/extensions/VisualEditor@master] ve.ce.MWGalleryNode: Ensure we always have a focusable element

https://gerrit.wikimedia.org/r/413253

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Feb 22 2018, 12:33 AM

Jdforrester-WMF removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Feb 22 2018, 1:00 AM

• Deskana closed this task as Resolved.Feb 22 2018, 11:03 AM

• Deskana set the point value for this task to 1.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 22 2018, 11:03 AM

Ryasmeen added a project: Verified.Feb 28 2018, 12:25 AM

Ryasmeen added projects: Verified-in-Phase0, Verified-in-Phase2.Mar 2 2018, 11:43 PM

	F13935448: image.png
	Feb 21 2018, 8:42 PM

	F13935446: image.png
	Feb 21 2018, 8:42 PM

	F14833: s1.png
	Feb 9 2015, 10:45 PM

Gallery with no images (invalid characters as gallery contents) creates an invisible node and can't be editedClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

Gallery with no images (invalid characters as gallery contents) creates an invisible node and can't be edited
Closed, ResolvedPublic1 Estimated Story Points
Actions