Page MenuHomePhabricator

VisualEditor: [Regression wmf7] Button in Add a Template dialog is labeled as "Hide Options", instead of "Show Options"
Closed, ResolvedPublic

Description

screenshot

Environment- beta

1> Select Insert -> Template
2> In the resulting add a template dialog the button is labeled "Hide Options".See screenshot.


Version: unspecified
Severity: major

Attached:

Details

Reference
bz73235

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz73235.
Swainr created this task.Nov 10 2014, 7:33 PM

Good finding!

It's in betalabs only. test2 and production display 'Show options' button.

gerritadmin wrote:

Change 172320 had a related patch set uploaded by Catrope:
Followup a86d824: fix stupid stupid logic inversion

https://gerrit.wikimedia.org/r/172320

gerritadmin wrote:

Change 172320 merged by jenkins-bot:
Followup a86d824: fix reference to this in foreach callback

https://gerrit.wikimedia.org/r/172320

gerritadmin wrote:

Change 172329 had a related patch set uploaded by Catrope:
Followup a86d824: fix reference to this in foreach callback

https://gerrit.wikimedia.org/r/172329

Verified the fix in betalabs.

gerritadmin wrote:

Change 172329 merged by jenkins-bot:
Followup a86d824: fix reference to this in foreach callback

https://gerrit.wikimedia.org/r/172329

Was a regression in wmf7, fix has been cherry-picked and deployed.

Verified the fix in test2

Checked in production.