Page MenuHomePhabricator

Create securepoll DB List to allow for customized definition of 'global'
Closed, ResolvedPublic

Description

Creating a separate dblist for securepoll to use which is coming up because of bug 72569 which requires us to eliminate labswiki from the list for securepoll in order for global elections to create (Brad thinks this fix is the easiest for now while we're waiting for that to resolve). However it is likely a good option regardless because it allows us to adjust the definition to eliminate wikis like loginwiki/zerowiki etc where we know we don't want people voting from. In the end we may want to eliminate more but will leave that up to the decision of the election committee.

I'll be submitting a patch for this shortly.


Version: wmf-deployment
Severity: normal

Details

Reference
bz73245

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:47 AM
bzimport set Reference to bz73245.
bzimport added a subscriber: Unknown Object (MLST).

Change 172449 had a related patch set uploaded by Jalexander:
Add SecurePoll specific dblist

https://gerrit.wikimedia.org/r/172449

Reedy added a comment.Nov 11 2014, 2:40 PM

It's also another maintenance burden... I'm guessing it's destined to be used by maintenance scripts, rather than in InitialiseSettings.php?

(In reply to Sam Reed (reedy) from comment #2)

It's also another maintenance burden... I'm guessing it's destined to be
used by maintenance scripts, rather than in InitialiseSettings.php?

No, $wgSecurePollCreateWikiGroups. Which is used in Special:SecurePoll/create.

Reedy added a comment.Nov 11 2014, 3:37 PM

default => true
nonbetafeatures => false
fishbowl => false
private => false

(In reply to Sam Reed (reedy) from comment #4)

default => true
nonbetafeatures => false
fishbowl => false
private => false

?

(In reply to Sam Reed (reedy) from comment #4)

default => true
nonbetafeatures => false
fishbowl => false
private => false

Came here to say the same. Just enable everywhere and disable on the irrelevant wikis by using existing lists.

Honestly I don't care how we do it, the important thing for me is to make it work (see bug 72569) and Brad said this was the way to do it for now. As he is the one who did the changes, I will bow to his expertise since I do not know if just disabling it will do what is necessary or not.

Brad: If this goes forward it's fine to just replace the 'global' option or if you need to add a new one you can add a message for it as Board Election or something like that. If we are going to just disable it on certain wikis the only one that matters for now is labswiki so that we can get the thing to work.

(In reply to Nemo from comment #6)

(In reply to Sam Reed (reedy) from comment #4)

default => true
nonbetafeatures => false
fishbowl => false
private => false

Came here to say the same. Just enable everywhere and disable on the
irrelevant wikis by using existing lists.

This comment does not make sense. I think you're arguing from faulty premises here, Nemo.

(In reply to Brad Jorsch from comment #8)

This comment does not make sense. I think you're arguing from faulty
premises here, Nemo.

I'm not arguing and I don't have any premise; I merely explained Reedy's comment.
Your comments are not particularly helpful, but we know very well that you're able to express yourself very clearly when you want. Are you trying to imply that you need to actually pass an array of DB names to the global rather than set a boolean value?

(In reply to Nemo from comment #9)

(In reply to Brad Jorsch from comment #8)

This comment does not make sense. I think you're arguing from faulty
premises here, Nemo.

I'm not arguing and I don't have any premise; I merely explained Reedy's
comment.

If you are correctly explaining Reedy's comment, then Reedy is also confused as to how this works.

$wgSecurePollCreateWikiGroups is a list of dblists and corresponding i18n messages that are offered to the user of [[Special:SecurePoll/create]] (which will typically be available only on votewiki, AFAIK) as options for "which wikis will this particular poll be accepting voters from". It is not a boolean setting that is enabled on individual wikis.

Change 172728 had a related patch set uploaded by Anomie:
Add securepoll-dblist-securepollglobal message

https://gerrit.wikimedia.org/r/172728

Change 172728 merged by jenkins-bot:
Add securepoll-dblist-securepollglobal message

https://gerrit.wikimedia.org/r/172728

Change 172770 had a related patch set uploaded by Anomie:
Add securepoll-dblist-securepollglobal message

https://gerrit.wikimedia.org/r/172770

Change 172770 merged by jenkins-bot:
Add securepoll-dblist-securepollglobal message

https://gerrit.wikimedia.org/r/172770

Thanks for answering

Change 172449 merged by jenkins-bot:
Add SecurePoll specific dblist and allow SecurePoll to use

https://gerrit.wikimedia.org/r/172449