Page MenuHomePhabricator
Create Task
Maniphest T75376

MessageDialog doesn't fit actions correctly
Closed, ResolvedPublic
Actions

Description

Switching to Edit source warning

In test2 VE - in Edit mode do some editing and click on 'Edit source' tab -

<span class="oo-ui-labelElement-label">Discard changes</span> is moved toward the right
<span class="oo-ui-labelElement-label">Keep changes</span> is displayed as cut off.

See the attached screenshot.

Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-11-13_at_8.59.07_AM.png (482×357 px, 49 KB)

Details

Reference
bz73376
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
MessageDialog: Fit actions after updating window size, not beforeBartosz Dziewońskioojs/uimaster+2 -3
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:55 AM
• bzimport added a project: VisualEditor-ContentEditable.
• bzimport set Reference to bz73376.
Etonkovidova created this task.Nov 13 2014, 5:06 PM
Jdforrester-WMF added a comment.Nov 19 2014, 12:32 AM
  • This bug has been marked as a duplicate of bug 70061 ***
matmarex renamed this task from VisualEditor: Switching to Edit source warning dialog box displays misaligned labels to MessageDialog doesn't fit actions correctly.Nov 24 2014, 8:37 PM
matmarex claimed this task.
matmarex mentioned this in T72061: Issues with dialog sizing on first open.
matmarex edited projects, added: OOUI; removed: VisualEditor-ContentEditable.
matmarex set Security to None.

Actually a separate issue, I think.

gerritbot added a project: Patch-For-Review.Nov 24 2014, 8:41 PM

Change 175503 had a related patch set uploaded (by Bartosz Dziewo?ski):
MessageDialog: Fit actions after updating window size, not before

https://gerrit.wikimedia.org/r/175503

Patch-For-Review

matmarex reopened this task as Open.Nov 24 2014, 8:42 PM
matmarex moved this task from Backlog to Next-up on the OOUI board.
Jdforrester-WMF triaged this task as High priority.Nov 24 2014, 9:49 PM
Jdforrester-WMF moved this task from Next-up to Doing on the OOUI board.Nov 24 2014, 10:28 PM
Jdforrester-WMF closed this task as Resolved.Nov 25 2014, 12:57 AM
gerritbot added a comment.Nov 25 2014, 12:59 AM

Change 175503 merged by jenkins-bot:
MessageDialog: Fit actions after updating window size, not before

https://gerrit.wikimedia.org/r/175503

Jdforrester-WMF added a project: WMF-deploy-2014-11-26-(1.25wmf10).Nov 25 2014, 1:10 AM
Etonkovidova added a project: Verified-in-Phase0.Dec 1 2014, 8:10 PM
Etonkovidova added a project: Verified-in-Phase2.Dec 4 2014, 12:38 AM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 19 2015, 9:36 PM
matmarex mentioned this in rGOJU5550d0ab715e: MessageDialog: Fit actions after updating window size, not before.Mar 3 2015, 7:49 PM
Jdforrester-WMF moved this task from Doing to Reviewing on the OOUI board.Mar 26 2015, 8:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits