Page MenuHomePhabricator

Table column adding icon must be flipped for RTL
Closed, ResolvedPublic

Description

The icons for adding columns in RTL must be flipped.


Version: unspecified
Severity: normal

Details

Reference
bz73379

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:55 AM
bzimport set Reference to bz73379.

Change 173310 had a related patch set uploaded by Esanders:
Make table inserts directional

https://gerrit.wikimedia.org/r/173310

Change 173310 merged by jenkins-bot:
Make table inserts directional

https://gerrit.wikimedia.org/r/173310

Just to confirm - for left-to-right we have:
<div class="ve-ce-tableNodeOverlay" style="top: 20.5833px; left: 25px;”>

and inserted table displays two arrows on the left.

For rtl(with the fix), we have:
<div class="ve-ce-tableNodeOverlay" style="top: 20.5833px; left: 754.267px;”> which makes the row arrow to appear at the left side and the column arrows appear on the right side - see the attached screenshot.

Shouldn't it be something like
<div class="ve-ce-tableNodeOverlay" style="top: 20.5833px; right: 25px;”> ? -see the attached screenshot

Created attachment 17137
rtl table with the fix

Attached:

Created attachment 17138
column row arrows - proposed correction?

Attached:

Jdforrester-WMF renamed this task from VisualEditor: Table column adding icon must be flipped for RTL to Table column adding icon must be flipped for RTL.Nov 24 2014, 12:27 AM
Jdforrester-WMF set Security to None.