Page MenuHomePhabricator
Create Task
Maniphest T75435

VisualEditor: Tables that are inserted into Media captions will display Table caption below the table
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Inserted table with caption

Steps to reproduce:

1 VE - Insert a media

  1. In Media Settings box insert a table and add a caption to a table. Click Insert.

The media will be inserted with a table and the table caption will be displayed below the table. The screenshot is attached.

Version: unspecified
Severity: minor

Attached:

Screen_Shot_2014-11-14_at_1.29.33_PM.png (483×333 px, 134 KB)

Details

Reference
bz73435
SubjectRepoBranchLines +/-
Fix caption-side for tables inside figcaptionsmediawiki/coremaster+5 -0
Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:59 AM
• bzimport added a project: VisualEditor-ContentEditable.
• bzimport set Reference to bz73435.
Etonkovidova created this task.Nov 14 2014, 9:38 PM
Etonkovidova added a comment.Nov 14 2014, 10:07 PM

Found in test2 and beta.

Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 4:04 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Nov 24 2014, 4:20 PM
• Whatamidoing-WMF added a project: VisualEditor-Tables.Dec 29 2014, 6:24 PM
• Whatamidoing-WMF set Security to None.
Esanders added a project: Parsoid.Jan 16 2016, 5:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2016, 5:27 PM
Esanders subscribed.Jan 16 2016, 5:28 PM

This is an upstream issue with how Parsoid styles <figcaption>s. This rule is inherited by the table's <caption>.

gerritbot subscribed.Jan 17 2016, 5:25 PM

Change 264600 had a related patch set uploaded (by Esanders):
Fix caption-side for tables inside figcaptions

https://gerrit.wikimedia.org/r/264600

gerritbot added a project: Patch-For-Review.Jan 17 2016, 5:25 PM
gerritbot added a comment.Jan 17 2016, 8:06 PM

Change 264600 merged by jenkins-bot:
Fix caption-side for tables inside figcaptions

https://gerrit.wikimedia.org/r/264600

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)).Jan 17 2016, 9:00 PM
Jdforrester-WMF moved this task from Freezer to TR1: Releases on the VisualEditor board.Jan 19 2016, 1:04 AM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF closed this task as Resolved.Jan 19 2016, 1:06 AM
Jdforrester-WMF assigned this task to Esanders.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL