Page MenuHomePhabricator

Upgrade Flow's copy of lightncandy to 0.18
Closed, ResolvedPublic

Description

Flow is currently using a modified copy of 0.15 with a patch that was declined by upstream (https://github.com/zordius/lightncandy/pull/104). A different patch for the bug was included in 0.16.

Diff: https://github.com/zordius/lightncandy/compare/v0.15...v0.18 (note that github conveniently doesn't display the diff for src/lightncandy.php which is really the only file that we care about)

Once this is done, we can work on bringing in Flow's dependencies via composer :) T86241

Details

Reference
bz73440
Related Gerrit Patches:
mediawiki/extensions/Flow : masterUpgrade Flow lightncandy to 0.18

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:59 AM
bzimport set Reference to bz73440.
bzimport added a subscriber: Unknown Object (MLST).
Legoktm created this task.Nov 14 2014, 10:33 PM
Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:41 AM

Note, https://lists.wikimedia.org/pipermail/design/2015-January/002229.html says

the template stuff is stalled on the Flow team conforming their code to upstream light-n-candy [this bug]

Legoktm renamed this task from Upgrade Flow's copy of lightncandy to 0.16 to Upgrade Flow's copy of lightncandy to 0.18.Jan 8 2015, 9:24 PM
Legoktm updated the task description. (Show Details)
Legoktm set Security to None.
Spage triaged this task as High priority.Jan 9 2015, 6:34 PM

I've tested Flow thoroughly (mostly no-JS, since that is rendered solely by lightncandy, but also JS to be on the safe side), and I found no issues with 0.18.

Upgrade patch for Flow is https://gerrit.wikimedia.org/r/#/c/185097/ .

gerritbot added a subscriber: gerritbot.

Change 185097 had a related patch set uploaded (by Mattflaschen):
Upgrade Flow lightncandy to 0.18

https://gerrit.wikimedia.org/r/185097

Patch-For-Review

Change 185097 merged by jenkins-bot:
Upgrade Flow lightncandy to 0.18

https://gerrit.wikimedia.org/r/185097

Spage updated the task description. (Show Details)Feb 23 2015, 4:28 AM