Page MenuHomePhabricator

Flow QA collapse browsertest should stop testing moderation
Closed, ResolvedPublic

Description

The scenario "For a moderated post, a mode cycle with no user override keeps it hidden" is broken. Its background creates then hides a topic, and then the test asserts

Given I am on Flow page 
Then I should not see a moderated message on the first moderated topic

In fact the moment Flow reloads a page (the "Given I am on Flow page"), the hidden topic that this test creates vanishes altogether. Often there happens to be a locked topic (which remains visible) lower down on the page, and the test finds it and fails at

features/collapse.feature:65:in `Then I should not see a moderated message on the first moderated topic'

So the test is irrelevant[1] and it intermittently fails.

I rewrote the test in gerrit 164720 to "remove moderated notion from collape tests". But we will remove the collapse switcher feature (Topics and posts > Topics only > Small topics) altogether when we implement a TOC for Flow boards, so it's probably easier to just kill that one part of the test right now.

[1] The actual feature to test is unrelated to collapsing, it is

Given I hide (or delete or suppress) a topic
Then ...
When I reload the page
Then I should not see hidden, deleted, or suppressed topics

gerrit 164655 is a step towards this.


Version: master
Severity: major

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 4:00 AM
bzimport set Reference to bz73451.
bzimport added a subscriber: Unknown Object (MLST).

See gerrit 164720

this patch removes the test completely. I would like to remove the test completely until the behavior is sane: https://gerrit.wikimedia.org/r/#/c/166727/

Change 166727 had a related patch set uploaded (by EBernhardson):
J-2e Remove all collapsing functionality

https://gerrit.wikimedia.org/r/166727

Patch-For-Review

EBernhardson triaged this task as Medium priority.Dec 11 2014, 1:09 AM
EBernhardson set Security to None.
Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:25 AM

Change 166727 merged by jenkins-bot:
J-2e Remove all collapsing functionality

https://gerrit.wikimedia.org/r/166727