Page MenuHomePhabricator

PHP notice in hhvm.log
Closed, ResolvedPublic

Description

Nov 15 12:45:44 mw1189: #012Notice: Undefined index: page_is_redirect in /srv/mediawiki/php-1.25wmf7/includes/api/ApiPageSet.php on line 295

I thought this one had been fixed already...


Version: 1.25-git
Severity: normal

Details

Reference
bz73464

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:45 AM
bzimport set Reference to bz73464.
bzimport added a subscriber: Unknown Object (MLST).
Reedy created this task.Nov 15 2014, 12:47 PM

This isn't the same issue that was fixed in bug 72764, the queries that worked there aren't logging the error anymore.

This one seems to be due to a query like https://en.wikipedia.org/w/api.php?action=query&revids=1&prop=info&redirects=1: the revids= parameter overrides the redirects= parameter, but that happens after ApiQueryInfo has decided not to call $pageset->requestField() based on the redirects= parameter.

Change 173839 had a related patch set uploaded by Anomie:
API: Always request page_is_redirect from ApiQueryInfo

https://gerrit.wikimedia.org/r/173839

Change 173839 merged by jenkins-bot:
API: Always request page_is_redirect from ApiQueryInfo

https://gerrit.wikimedia.org/r/173839