Page MenuHomePhabricator

Avoid type hints against Item in EntityParserOutputGenerator
Closed, InvalidPublic


EntityParserOutputGenerator contains special case code for Items. This should be changed to check against a light weight interface like SiteLinkListProvider.

Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=0



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:47 AM
bzimport set Reference to bz73495.
bzimport added a subscriber: Unknown Object (MLST).

The concrete issue pointed out is fixed by

However, there is still an OCP violation.

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
daniel renamed this task from Remove incorrect Entity assumptions from EntityParserOutputGenerator to Avoid type hints against Item in EntityParserOutputGenerator.Feb 4 2016, 2:48 PM
daniel updated the task description. (Show Details)
daniel set Security to None.
thiemowmde claimed this task.
thiemowmde subscribed.

There is only 1 occurrence of Item in EntityParserOutputGenerator, and it does not block the introduction of a possible SiteLinkProvider interface. Item currently acts as a SiteLinkListProvider. I don't see this blocking anything.

thiemowmde changed the task status from Resolved to Invalid.Feb 4 2016, 4:14 PM