Avoid type hints against Item in EntityParserOutputGenerator
Closed, InvalidPublic
Actions

Assigned To

Authored By

	JeroenDeDauw
	Nov 16 2014, 8:53 PM

Description

EntityParserOutputGenerator contains special case code for Items. This should be changed to check against a light weight interface like SiteLinkListProvider.

Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=0

Details

Reference: bz73495

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		thiemowmde	T75495 Avoid type hints against Item in EntityParserOutputGenerator
		Open		None	T125823 Introduce SiteLinkProvider interface

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:47 AM

• bzimport added a project: MediaWiki-extensions-WikibaseRepository.

• bzimport set Reference to bz73495.

• bzimport added a subscriber: Unknown Object (MLST).

JeroenDeDauw created this task.Nov 16 2014, 8:53 PM

The concrete issue pointed out is fixed by https://gerrit.wikimedia.org/r/#/c/175774/

However, there is still an OCP violation.

Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:26 PM

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).

daniel renamed this task from Remove incorrect Entity assumptions from EntityParserOutputGenerator to Avoid type hints against Item in EntityParserOutputGenerator.Feb 4 2016, 2:48 PM

daniel updated the task description. (Show Details)

daniel set Security to None.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2016, 2:48 PM

daniel removed a parent task: T75496: [Epic] Support new types of Entities in Wikibase Repository.Feb 4 2016, 2:48 PM

There is only 1 occurrence of Item in EntityParserOutputGenerator, and it does not block the introduction of a possible SiteLinkProvider interface. Item currently acts as a SiteLinkListProvider. I don't see this blocking anything.

thiemowmde changed the task status from Resolved to Invalid.Feb 4 2016, 4:14 PM

Avoid type hints against Item in EntityParserOutputGeneratorClosed, InvalidPublicActions