Page MenuHomePhabricator

Mediawiki diff formatting is broken in printer ready display
Closed, ResolvedPublic

Description

Author: chrislewellyn

Description:
Printable diffs now contain a hideous combination of the old and new diff styles.

Compare:

http://en.wikipedia.org/w/index.php?title=Talk%3AMain_Page&diff=634264072&oldid=634103051 (non-printable)

and:

http://en.wikipedia.org/w/index.php?title=Talk%3AMain_Page&diff=634264072&oldid=634103051&printable=yes (printer ready)

Additionally, while it might not be classified as a bug, the new styling for diffs is just awful. The old style may not have had all those rounded corners the kids like these days, but they were compact and readable. The new style is an unreadable eyesore, which I'd describe as style over substance if it had any style to it.

An acceptable fix for this bug would be simply to revert all those changes.


Version: 1.25-git
Severity: normal

Details

Reference
bz73544

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:50 AM
bzimport set Reference to bz73544.

(In reply to Chris Davies from comment #0)

Additionally, while it might not be classified as a bug, the new styling for
diffs is just awful. The old style may not have had all those rounded
corners the kids like these days, but they were compact and readable. The
new style is an unreadable eyesore, which I'd describe as style over
substance if it had any style to it.

By "new style", you mean the one introduced in… 2010 or so? This bug is probably not the right place to discuss it.

Something is definitely wrong with the print styles, though.

gerritadmin wrote:

Change 174101 had a related patch set uploaded by Bartosz Dziewoński:
mediawiki.action.history.diff: Rework print styles

https://gerrit.wikimedia.org/r/174101

gerritadmin wrote:

Change 174101 merged by jenkins-bot:
mediawiki.action.history.diff: Rework print styles

https://gerrit.wikimedia.org/r/174101

Fixed!

The change will be deployed on Wikimedia wikis according to the schedule at [[mw:MediaWiki 1.25/Roadmap]], as part of the 1.25wmf9 version.