Page MenuHomePhabricator

VisualEditor: Improve FileDropHandler API
Open, MediumPublicFeature


From comments at :

  • Right now every child class calls createProgress( insertableDataDeferred.promise() ); in its process() method. This seems like something that should be in the base class instead. Would you ever want to not do that, or pass a different promise?
  • Child classes should not have to override abort() just to add this.reader.abort();, because this.reader is added by the base class.

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:51 AM
bzimport added a project: Technical-Debt.
bzimport set Reference to bz73570.
Jdforrester-WMF lowered the priority of this task from High to Medium.Jan 9 2015, 10:55 PM
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 12:23 PM