Page MenuHomePhabricator

Host crossdomain.xml master policy file
Closed, DeclinedPublic

Description

To give us more options for mitigating issues like T73478, we really should have a master cross-domain policy file for all WMF domains that restricts any cross-domain policies served on the domain.

Either:

<?xml version="1.0"?>
<!DOCTYPE cross-domain-policy SYSTEM
"http://www.adobe.com/xml/dtds/cross-domain-policy.dtd">
<cross-domain-policy>
 <site-control permitted-cross-domain-policies="none"/>
</cross-domain-policy>

or if we really need any cross-domain flash access, specify them by domain:

<?xml version="1.0"?>
<!DOCTYPE cross-domain-policy SYSTEM
"http://www.adobe.com/xml/dtds/cross-domain-policy.dtd">
<cross-domain-policy>
 <site-control permitted-cross-domain-policies="master-only"/>
 <allow-access-from domain="*.example.com"/>
</cross-domain-policy>

Version: unspecified
Severity: normal

Details

Reference
bz73574

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:52 AM
bzimport added a project: Security-Other.
bzimport set Reference to bz73574.
bzimport changed Security from none to Software security bug.
Restricted Application changed the visibility from "Public (No Login Required)" to "acl*security (Project)". · View Herald TranscriptNov 22 2014, 3:52 AM
Restricted Application changed the edit policy from "All Users" to "acl*security (Project)". · View Herald Transcript

Since you mention "all WMF domains": upload.wikimedia.org has a very open crossdomain.xml:

<?xml version="1.0"?>
<!DOCTYPE cross-domain-policy SYSTEM "http://www.adobe.com/xml/dtds/cross-domain-policy.dtd">
<cross-domain-policy>
  <allow-access-from domain="*" />
</cross-domain-policy>

This was the request of both internal applications that needed to do cross-domain requests from our own projects (e.g. ogv.js), as well as third-party users of upload.wikimedia.org.

JFYI, in case that results in a security issue I could not think of.

Restricted Application changed the visibility from "acl*security (Project)" to "Custom Policy". · View Herald TranscriptNov 24 2014, 12:09 PM
Restricted Application changed the edit policy from "acl*security (Project)" to "Custom Policy". · View Herald Transcript
Restricted Application added a project: acl*security. · View Herald Transcript

Thank faidon, I forgot about upload. That one can be open because we're not supposed to put anything sensitive there. I'll try to get this setup for all the rest of our domains.

Restricted Application changed the visibility from "Custom Policy" to "Custom Policy". · View Herald TranscriptNov 24 2014, 11:05 PM
Restricted Application changed the edit policy from "Custom Policy" to "Custom Policy". · View Herald Transcript
csteipp added a project: Security-Team.
tstarling changed the visibility from "Custom Policy" to "Public (No Login Required)".
tstarling changed the edit policy from "Custom Policy" to "All Users".