Page MenuHomePhabricator

Surface is not destroyed when you exit VE if you ever opened the save dialog
Closed, ResolvedPublic

Description

  1. Edit page
  2. Insert table
  3. Load save dialog
  4. Review diff
  5. Resume editing
  6. Exit to read mode discarding changes

Observe the new table still being there, and you can even highlight cells, load the link editor, etc..


Version: unspecified
Severity: normal

Details

Reference
bz73589
Related Gerrit Patches:

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:53 AM
bzimport set Reference to bz73589.
  • Bug 73590 has been marked as a duplicate of this bug. ***
Krenair renamed this task from VisualEditor: Viewing the diff before exiting to read mode without saving leaves the editor active to VisualEditor: Surface is not destroyed when you exit VE if you ever opened the save dialog.Nov 23 2014, 10:30 PM
Krenair set Security to None.
Jdforrester-WMF renamed this task from VisualEditor: Surface is not destroyed when you exit VE if you ever opened the save dialog to Surface is not destroyed when you exit VE if you ever opened the save dialog.Nov 24 2014, 4:48 AM
Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Nov 25 2014, 3:11 AM

Change 175217 merged by jenkins-bot:
Only try to close save dialog before destroying surface if it's currently open

https://gerrit.wikimedia.org/r/175217

ori moved this task from Backlog to Done on the VisualEditor-Performance board.Feb 21 2015, 6:13 AM