Page MenuHomePhabricator

Echo DiscussionParser has wrong interpretation for some revisions
Open, HighPublic

Description

I ran a quick test of the EchoDiscussionParser against en:Wikipedia_talk:Flow, looking through the results there are a number of edits that were incorrectly identified and would not have triggered some notifications:

New signed comments(with or without new section) detected as unknown-unsigned-addition:

555270107
555295098
555299660
555302637
555424784
555555975
556448096
556548225
557964217
561992140
562035095
562134287
562145243
562195663
562328306
563261166
563273980 (has a P.s. after signature which mucks things up)
563791954
564297017
564303386
564304143
564408749
564451754

New signed comments(with or without new section) detected as unknown-multi-signed-addition:

561896252
561900489
561992140
562302288
562304268
562305412
562331009
564455983
564459880

There are about 16 more pgdown's (of revid+change+content), this is enough to get an idea of the problem. Use the following script to recreate:

<?php

$page = WikiPage::factory( Title::newFromText( 'Wikipedia_talk:Flow' ) );
if ( !$page->getId() ) {
    throw new Exception( "Page does not exist" );
}

$it = new EchoBatchRowIterator(
    wfGetDB( DB_SLAVE ),
    'revision',
    'revision_id',
    500
);
$it->addConditions( array(
    'rev_page' => $page->getId();
    'rev_deleted' => 0,
) );
$it = new RecursiveIteratorIterator( $it );

foreach ( $it as $row ) {
    $revision = Revision::newFromId( $row->rev_id );
    $interp[$row->rev_id] = EchoDisussionParser::getChangeInterpretationForRevision( $revision );
}   

echo json_encode( $interp );

Details

Reference
bz73635

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:55 AM
bzimport added a project: Notifications.
bzimport set Reference to bz73635.
bzimport added a subscriber: Unknown Object (MLST).
Mattflaschen-WMF renamed this task from Wrong interpretation of revisions to Echo DiscussioParser has wrong interpretation for some revisions.Dec 10 2014, 7:03 PM
Mattflaschen-WMF triaged this task as High priority.
Mattflaschen-WMF set Security to None.
Legoktm updated the task description. (Show Details)Jul 6 2015, 7:53 AM
Legoktm moved this task from Backlog to Needs plan on the Notifications board.
Quiddity renamed this task from Echo DiscussioParser has wrong interpretation for some revisions to Echo DiscussionParser has wrong interpretation for some revisions.Apr 28 2016, 2:37 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 6:44 PM
SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Jul 20 2018, 5:53 PM