I was just trying to change the user I was attached to (I accidentally somehow have to mediawiki accounts, and had signed up with the wrong one) so I signed in to phabricator then signed out on mediawiki before pressing the refresh button on the /settings/panel/external/ page (which no longer works, probably because two accounts).

I just tried removing the second account to see if it would 'fix' this, but it does exactly the same thing.

What we can do is to delete this account, I guess. Let's wait until @mmodell is back, he might be interested in more details before deleting your account, in order to prevent this problem.

Revoking the permissions from the mediawiki side doesn't seem to fix things. I can still log in and do everything but look at my profile I think.

I guess the solution is that the plugin shouldn't allow users to add a second Wikimedia username? One Phabricator account for one Wikimedia SUL account.

@fbstj can you access https://phabricator.wikimedia.org/settings/panel/external/ and remove one of the two Wikimedia accounts?

Yeah I can access that page, in T75720#777867 I both tried to remove or refresh either of the connections and they both respond with the same error:

Unhandled Exception ("AphrontCountQueryException")
More than 1 result from loadOneWhere()!

The refresh button loads a new page where that's the only content, where the remove button brings up an error dialogue.

@fbstj, there is a discussion upstream. Basically, they cannot reproduce the steps to attach two accounts.

@fbstj you're really popular here! :)

I wonder whether we can clean our database to fix this specific case here, while waiting for the upstream path to prevent users running into this situation again.

That would be great, it'd be nice to have a profile I can visit/configure XD

Any news on cleaning the database record?

@mmodell would probably know best since he wrote the majority of the oauth extension (or all of it?)

@mmodell: Ping on the last two comments

Sorry this flew under my radar somehow.

It looks like it's a phab bug, not specific to any code that I wrote, however, I might be able to figure out a solution. I'll poke at it.

Reported upstream: https://secure.phabricator.com/T6707

Any news on cleaning the database record?

For the specific case of @fbstj, I guess someone needs to delete one row in the user_externalaccount table in the phabricator_user DB?
Imaginary SQL to find that data: USE phabricator_user; SELECT * FROM user_externalaccount JOIN user WHERE user_externalaccount.userPHID = user.phid AND user.userName = "fbstj";
(And I'm not sure if user_externalaccount.userPHID needs to be user_externalaccount.accountID instead here, still trying to understand that scheme more.)

@mmodell: Could you take a look at that if you find 5 minutes and if things don't seem too risky?

Thanks for taking a look :) apologies for taking peoples time from the more interesting tasks

so which external account is the valid one? I don't want to delete the wrong one.

Fbstj or Fbstjoe ?

fbstj is the good one, fbstjoe is one I'd like delete/merging tbh

Done.

delete from user_externalaccount where accountURI='https://www.mediawiki.org:/w/index.php?title=User%3AFbstjoe';

Query OK, 1 row affected (0.01 sec)

Thank you so much :D

What about other affected users? They should wait or they should ask it to be fixed?

I am another affected user :D

@Teles: if you tell me which account to remove then I can remove it for you, but I don't want to remove the one you use to log in so I won't take any action until I know for sure.

In T75720#1500546, @mmodell wrote:

@Teles: if you tell me which account to remove then I can remove it for you, but I don't want to remove the one you use to log in so I won't take any action until I know for sure.

@mmodel, thanks!
The one that should be removed is "Telles" (with two "L")

@Teles: Done

Should be fixed in upstream by https://secure.phabricator.com/rPb038041dc600448c81c06c7b0f64c0d009245ca8