Page MenuHomePhabricator

MessageDialog does not re-fit actions on dialog resize
Closed, ResolvedPublic

Description

MessageDialog does not re-fit actions on dialog resize.

Discovered when working on T72061.

Event Timeline

matmarex created this task.Nov 24 2014, 8:33 PM
matmarex updated the task description. (Show Details)
matmarex raised the priority of this task from to Needs Triage.
matmarex added a project: OOUI.
matmarex changed Security from none to None.
matmarex added a subscriber: matmarex.
matmarex moved this task from Backlog to Next-up on the OOUI board.Nov 24 2014, 8:48 PM
matmarex renamed this task from Process and Message dialog do not re-fit label/actions on window resize to MessageDialog do not re-fit actions on window resize.Nov 24 2014, 9:18 PM
matmarex updated the task description. (Show Details)

Change 175543 had a related patch set uploaded (by Bartosz Dziewo?ski):
[WIP] MessageDialog: Fit actions again when the dialog is resized

https://gerrit.wikimedia.org/r/175543

Patch-For-Review

This turned out to be more difficult that it looked, because we have to take into account that the size is being smoothly transitioned. We should use the final size in the calculations somehow, and then wait for the transition to finish. The patch above doesn't really work.

matmarex moved this task from Next-up to Backlog on the OOUI board.Nov 24 2014, 9:23 PM
Jdforrester-WMF triaged this task as Normal priority.Nov 24 2014, 9:50 PM
Jdforrester-WMF moved this task from Backlog to Next-up on the OOUI board.Nov 26 2014, 11:10 PM
matmarex renamed this task from MessageDialog do not re-fit actions on window resize to MessageDialog do not re-fit actions on dialog resize.Nov 29 2014, 5:45 PM
matmarex updated the task description. (Show Details)
matmarex claimed this task.
matmarex renamed this task from MessageDialog do not re-fit actions on dialog resize to MessageDialog does not re-fit actions on dialog resize.Nov 29 2014, 9:43 PM
matmarex updated the task description. (Show Details)

Change 175543 merged by jenkins-bot:
MessageDialog: Fit actions again when the dialog is resized

https://gerrit.wikimedia.org/r/175543

Jdforrester-WMF moved this task from Next-up to Reviewing on the OOUI board.Mar 26 2015, 8:57 PM