Page MenuHomePhabricator
Create Task
Maniphest T75823

LinkCache sends API requests for URL-encoded page names, gets "invalid" responses back when descending into template contents
Closed, ResolvedPublic
Actions

Description

Observed this happening for dozens of links on https://en.wikipedia.org/wiki/Barack_Obama

Minimal test case: create a page with [["Foo bar"]] {{echo|[["Bar baz"]]}}. Load the page in VE while watching the network tab in the web inspector, filtering for XHR requests. Observe an API request is sent for %22Bar_baz%22 but not for %22Foo_bar%22 or "Foo_bar" or anything else.

Details

SubjectRepoBranchLines +/-
Handle encoding of links in transclusion nodes properly when determining existencemediawiki/extensions/VisualEditormaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Nov 25 2014, 3:37 AM
Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added a project: VisualEditor.
Catrope changed Security from none to None.
Catrope subscribed.
Jdforrester-WMF triaged this task as Medium priority.Nov 25 2014, 7:57 PM
Jdforrester-WMF added projects: VisualEditor-Performance, VisualEditor-MediaWiki.
Jdforrester-WMF moved this task from To Triage to Bug Fixes on the VisualEditor board.
Krenair subscribed.Dec 1 2014, 7:55 PM

I ran into T76379: [Regression?] Links in transclusion nodes can point to /w/PageName if browsing from /w/index.php?veaction=edit when doing this

gerritbot added a project: Patch-For-Review.Dec 2 2014, 1:09 AM

Change 176857 had a related patch set uploaded (by Alex Monk):
Handle encoding of links in transclusion nodes properly when determining existence

https://gerrit.wikimedia.org/r/176857

Patch-For-Review

Krenair claimed this task.Dec 2 2014, 1:09 AM
Jdforrester-WMF moved this task from Bug Fixes to Blocked on the VisualEditor board.Dec 2 2014, 10:19 PM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Dec 2 2014, 10:21 PM
gerritbot added a comment.Dec 2 2014, 10:22 PM

Change 176857 merged by jenkins-bot:
Handle encoding of links in transclusion nodes properly when determining existence

https://gerrit.wikimedia.org/r/176857

Krenair closed this task as Resolved.Dec 2 2014, 10:27 PM
Krenair mentioned this in rEVEDc2ed5201e547: Handle encoding of links in transclusion nodes properly when determining….Dec 10 2014, 7:26 PM
Jdforrester-WMF removed a project: Patch-For-Review.Dec 15 2014, 9:22 PM
Jdforrester-WMF added a project: WMF-deploy-2015-01-07_(1.25wmf14).Jan 16 2015, 7:26 PM
ori moved this task from Backlog to Done on the VisualEditor-Performance board.Feb 21 2015, 6:13 AM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Aug 5 2015, 1:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL