"Sidebar searches on old bugzilla are broken because special characters have been URL encoded. Or, they are correctly URL encoded, but not converted back by the search engine.
e.g. it'd try to search for foobar%40gmail.com for "My Bugs" which doesn't work."
(Mentioned by someone else on IRC. I'm filing on behalf of.)
screenshot of a named search with spaces in the title:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Attempt to fix double-encoding in old-bugzilla HTTPS redirects | Gergő Tisza | operations/puppet | production | +2 -2 |
I can confirm that but no idea why. Would be great to know if anybody knows if that still worked 24h ago as we moved old-bugzilla behind the misc-web varnish/nginx layer about 12h ago (T366).
Workaround: remove the "25"s from the URL.
Comparison:
https://old-bugzilla.wikimedia.org/buglist.cgi?namedcmd=Time%3A%20New%20Bugs%20-%2024%20Hours&cmdtype=dorem&remaction=run&sharer_id=1234 https://old-bugzilla.wikimedia.org/buglist.cgi?namedcmd=Time%253A%2520New%2520Bugs%2520-%252024%2520Hours&cmdtype=dorem&remaction=run&sharer_id=1234
This also seems to make the 'My bugs' link in the sidebar not work for me (url encoding the @ symbol in my username), and also breaks many of the component bug lists, ie https://old-bugzilla.wikimedia.org/buglist.cgi?component=PDF%20renderer&list_id=360888&product=OCG&resolution=---
Workaround: For the time being, it works for me in Firefox 33 to remove the "25" string after any percentage signs in the URL and loading that new URL again.
When I enter
https://old-bugzilla.wikimedia.org/buglist.cgi?cmdtype=runnamed&namedcmd=UploadWizard%20bugs
the site will return a
Location: http://old-bugzilla.wikimedia.org/buglist.cgi?cmdtype=runnamed&namedcmd=UploadWizard%20bugs&list_id=360937
redirect (this is Bugzilla resolving the saved search name to a search id, and for some reason redirecting to HTTP at the same time), which is then followed by
Location: https://old-bugzilla.wikimedia.org/buglist.cgi?cmdtype=runnamed&namedcmd=UploadWizard%2520bugs&list_id=360937
So there are two separate bugs:
Bug #2 can be demonstrated in isolation
$ curl -vso/dev/null 'http://old-bugzilla.wikimedia.org/foo?bar%20baz' 2>&1 | grep Location < Location: https://old-bugzilla.wikimedia.org/foo?bar%2520baz
The bug only affects the query string, percent signs in the path part are left intact.
Change 178186 had a related patch set uploaded (by Gergő Tisza):
Attempt to fix double-encoding in old-bugzilla HTTPS redirects
Change 178186 merged by Dzahn:
Attempt to fix double-encoding in old-bugzilla HTTPS redirects
I merged your change and puppet applied on zirconium. I graceful'ed Apache. Now:
curl -vso/dev/null 'http://old-bugzilla.wikimedia.org/foo?bar%20baz' 2>&1 | grep Location
< Location: https://old-bugzilla.wikimedia.org/foo?bar%20baz
looks fixed to me from that. thanks Gergő !
logged in on old-BZ and clicked sidebar searches. they work for me. claiming ticket is resolved but confirmation would be nice.