Page MenuHomePhabricator

Implement file usage limits in parsing
Open, HighPublic

Description

Investigating "mysql gone-away errors" I saw a huge backtrace (the whole file basically) in the HHVM fatal log of someone trying to parse an 80k line gallery. Probably would be nice to limit that.

Event Timeline

aaron created this task.Nov 26 2014, 1:40 AM
aaron updated the task description. (Show Details)
aaron raised the priority of this task from to Needs Triage.
aaron added a project: MediaWiki-Core-Team.
aaron moved this task to Backlog on the MediaWiki-Core-Team board.
aaron changed Security from none to None.
aaron added a subscriber: aaron.
GWicke triaged this task as High priority.Apr 25 2015, 7:39 PM
GWicke added a subscriber: GWicke.EditedApr 25 2015, 7:47 PM

Bumping priority, as Incident-20150423-Commons was largely caused by huge galleries with large DjVu files loading megabytes of image metadata (also see T96360).

Now at https://en.wikipedia.org/wiki/User_talk:Magog_the_Ogre/Archive_32#Putting_limits_on_number_of_images_per_gallery_generated_by_OgreBot

Bumping priority, as Incident-20150423-Commons was largely caused by huge galleries with large DjVu files loading megabytes of image metadata (also see T96360).

Note, img_metadata for paged files is many orders of magnitude bigger than for "normal" files.

greg added a subscriber: greg.Sep 29 2016, 7:42 PM

This follow-up task from an incident report has not been updated recently. If it is no longer valid, please add a comment explaining why. If it is still valid, please prioritize it appropriately relative to your other work. If you have any questions, feel free to ask me (Greg Grossmeier).

We'll talk about this at our upcoming offsite.