Page MenuHomePhabricator

OAuth login isn't working
Closed, ResolvedPublic

Description

As of the last few hours, OAuth login does not appear to be working for any consumers.

I've tested these:

http://quarry.wmflabs.org/
http://wizard.wikiedu.org
http://tools.wmflabs.org/oauth-hello-world/

Event Timeline

Ragesoss raised the priority of this task from to Unbreak Now!.
Ragesoss updated the task description. (Show Details)
Ragesoss changed Security from none to None.
Ragesoss subscribed.
greg added a subscriber: Gage.
greg subscribed.

I couldn't login to Phab via mw.org, I got:

Unhandled Exception ("Exception")
Expected 'oauth_token' in response!

This is currently being debugged in -operations.

Just a sanity check. I verified the consumer key matches between phab and MW.

https://www.mediawiki.org/wiki/Special:OAuthListConsumers/view/211867c109f5b97b392082965a1abd4b

The phab config hasn't changed I don't believe. Just a sanity check.

Tim confirmed this was due to the fact that the Authorization HTTP header was unavailable to HHVM or Zend in the form of a $_SERVER variable, but Zend appservers were still getting it from apache_request_headers(). The fix is to trick apache in sending that header to the fastcgi server via a SetEnvIf:

https://gerrit.wikimedia.org/r/#/c/175952/

This is being deployed right now. We'll confirm if this is enough and close the ticket in case

tstarling claimed this task.

Looks fixed to me.