Page MenuHomePhabricator
Create Task
Maniphest T76021

[Task] Create extension mechanism for Wikibase Repository
Closed, ResolvedPublic
Actions

Description

In order to support new entity types in Wikibase Repository, extensions need to be able to register handlers for the entity types they add. There are dozens of types of such handlers that need to be registrable. (Not just for new entity types.)

At present most handler lists are set in the top level factory (WikibaseRepo), or are being refactored towards being set there.

Example: getEntityIdParser in WikibaseRepo provides an EntityIdParser to the rest of the code, avoiding the using code to bind to any specific parsers or global state. This method that constructs it can add support for new types of entity ids, though it needs to somehow get the information from the extensions.

Details

SubjectRepoBranchLines +/-
Use EntityTypeDefinitions in repo and clientmediawiki/extensions/Wikibasemaster+132 -37
Create entity type registrymediawiki/extensions/Wikibasemaster+316 -14
Use $wgContentHandlers to register custom handlersmediawiki/extensions/Wikibasemaster+11 -28
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 DuplicateNoneT66288 basic support for structured data on mediawiki files
 InvalidLydia_PintscherT76012 make use of new entity type for multimedia / structured data of media files
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 OpenNoneT67626 [Epic] Support for queries on-wiki (automated list generation)
 ResolvedAddshoreT76019 [Story] Support new types of Entities in Wikibase Client
 ResolvedthiemowmdeT135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
 ResolvedAddshoreT75496 [Epic] Support new types of Entities in Wikibase Repository
 ResolveddanielT129348 Inject entity services via callback definitions
 ResolvedBeneT76021 [Task] Create extension mechanism for Wikibase Repository

Event Timeline

JeroenDeDauw created this task.Nov 26 2014, 4:06 PM
JeroenDeDauw raised the priority of this task from to High.
JeroenDeDauw updated the task description. (Show Details)
JeroenDeDauw added a project: MediaWiki-extensions-WikibaseRepository.
JeroenDeDauw changed Security from none to None.
JeroenDeDauw added subscribers: Unknown Object (MLST), thiemowmde, hoo and 6 others.
JeroenDeDauw added a comment.Nov 26 2014, 4:10 PM

We could just bolt the whole pile of extension points on top of the WikibaseRepo class. Then extensions to Wikibase Repository could do something like

$wikibaseRepo->registerEntityIdParser( $myNewEntityIdParser );

This will add a lot of state to WikibaseRepo, which already has quite some state (though all state with a different purpose). Adding a distinct service that is then used by WikibaseRepo is probably better. Looking into this more before actually making changes is advised, since changing it later will be difficult.

JanZerebecki subscribed.Nov 26 2014, 4:55 PM
Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:23 PM
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.Dec 27 2014, 2:31 PM
JeroenDeDauw added a comment.Feb 26 2015, 7:15 PM

Duplicate: https://phabricator.wikimedia.org/T77985

adrianheine subscribed.Feb 27 2015, 8:10 AM
JanZerebecki renamed this task from Create extension mechanism for Wikibase Repository to Create extension mechanism for Wikibase Repository for new entity types.Feb 27 2015, 11:08 AM
GPHemsley merged a task: T77985: Add mechanism for registering new entity types, to work with things like EntityViewFactory.Feb 27 2015, 1:10 PM
GPHemsley added a subscriber: Aklapper.
JeroenDeDauw renamed this task from Create extension mechanism for Wikibase Repository for new entity types to Create extension mechanism for Wikibase Repository.Feb 27 2015, 1:12 PM
JeroenDeDauw updated the task description. (Show Details)
Ricordisamoa subscribed.Aug 22 2015, 2:14 PM
daniel added a comment.Feb 4 2016, 2:57 PM

One way to go about this is to add factory methods for all the relevant services to the EntityHandler sublcass for the respective entity type. Since MediaWiki already has a registry for ContentHandlers, and each entity type is bound to a content model, this should work fine. All that is needed at the root is a list of all relevant content models, this already exists, and can be modified via the WikibaseContentModelMapping hook.

However, any entity type specific code needed on the client cannot use this mechanism, since the EntityHandler is not (and should not be) present on the client. This is true in particular for the serializer and unserializer.

Bene renamed this task from Create extension mechanism for Wikibase Repository to [Task] Create extension mechanism for Wikibase Repository.Feb 5 2016, 1:10 PM
Bene subscribed.
gerritbot subscribed.Feb 5 2016, 1:43 PM

Change 268667 had a related patch set uploaded (by Bene):
Use $wgContentHandlers to register custom handlers

https://gerrit.wikimedia.org/r/268667

gerritbot added a project: Patch-For-Review.Feb 5 2016, 1:43 PM
Bene claimed this task.Feb 5 2016, 1:44 PM
Bene edited projects, added Wikidata-Sprint-2016-02-02; removed Patch-For-Review.
Bene added a project: Patch-For-Review.
Bene removed a subscriber: gerritbot.
Bene moved this task from Proposed to Doing on the Wikidata-Sprint-2016-02-02 board.Feb 5 2016, 1:59 PM
JeroenDeDauw added a comment.Feb 6 2016, 7:38 AM

@daniel: this task is not just about entity types. As for forcing such extensions to bind to content handler... this really does not seem nice dependency wise.

gerritbot added a comment.Feb 9 2016, 7:24 PM

Change 268667 merged by jenkins-bot:
Use $wgContentHandlers to register custom handlers

https://gerrit.wikimedia.org/r/268667

Bene mentioned this in T126932: [Task] Support serialization of additional entities.Feb 14 2016, 7:12 PM
gerritbot added a comment.Feb 14 2016, 9:52 PM

Change 270643 had a related patch set uploaded (by Bene):
[DNM] Draft entity type registry

https://gerrit.wikimedia.org/r/270643

Lydia_Pintscher added a project: Wikidata-Sprint-2016-02-16.Feb 16 2016, 2:17 PM
Bene moved this task from Proposed to Doing on the Wikidata-Sprint-2016-02-16 board.Feb 16 2016, 3:01 PM
Lydia_Pintscher moved this task from needs discussion or investigation to in progress on the Wikidata board.Feb 18 2016, 12:05 PM
Bene moved this task from Doing to Done on the Wikidata-Sprint-2016-02-16 board.Feb 21 2016, 11:35 PM
Bene moved this task from Done to Review on the Wikidata-Sprint-2016-02-16 board.
Lydia_Pintscher added a project: Wikidata-Sprint-2016-03-01.Mar 1 2016, 1:56 PM
Lydia_Pintscher moved this task from Proposed to Review on the Wikidata-Sprint-2016-03-01 board.Mar 1 2016, 2:36 PM
Tobi_WMDE_SW moved this task from Review to Doing on the Wikidata-Sprint-2016-03-01 board.Mar 2 2016, 11:02 AM
gerritbot added a comment.Mar 2 2016, 5:57 PM

Change 270643 merged by jenkins-bot:
Create entity type registry

https://gerrit.wikimedia.org/r/270643

gerritbot added a comment.Mar 2 2016, 8:01 PM

Change 271140 had a related patch set uploaded (by Bene):
Use EntityTypeDefinitions in repo and client

https://gerrit.wikimedia.org/r/271140

gerritbot added a comment.Mar 3 2016, 11:46 AM

Change 271140 merged by jenkins-bot:
Use EntityTypeDefinitions in repo and client

https://gerrit.wikimedia.org/r/271140

Bene closed this task as Resolved.Mar 3 2016, 12:58 PM
Bene moved this task from Doing to Done on the Wikidata-Sprint-2016-03-01 board.
Bene closed subtask T126932: [Task] Support serialization of additional entities as Resolved.Mar 8 2016, 7:18 PM
Bene closed subtask T127191: [Task] Allow extensions to register additonal EntityViews as Resolved.
Bene added a parent task: T129348: Inject entity services via callback definitions.Mar 9 2016, 1:57 PM
Bene removed subtasks: T127191: [Task] Allow extensions to register additonal EntityViews, T126932: [Task] Support serialization of additional entities.
Bene mentioned this in T129348: Inject entity services via callback definitions.
Bene removed a parent task: T75496: [Epic] Support new types of Entities in Wikibase Repository.Mar 9 2016, 1:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL