Page MenuHomePhabricator

[Regression wmf10] Changes in the caption surface in MediaDialog does not enable the "Apply" button
Closed, ResolvedPublic

Description

It seems the event listener has changed for the surfaceWidget, which led to the dialog not "knowing" when changes were made to the caption surface.

The old event "documentUpdate" should be switched to "transact" on the model.

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterChange event listener for caption surface in media dialog
mediawiki/extensions/VisualEditor : wmf/1.25wmf10Set panels after everything is initialized in media dialog
mediawiki/extensions/VisualEditor : masterSet panels after everything is initialized in media dialog

Event Timeline

Mooeypoo created this task.Nov 26 2014, 8:03 PM
Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo added a project: VisualEditor.
Mooeypoo changed Security from none to None.
Mooeypoo added a subscriber: Mooeypoo.

Change 176028 had a related patch set uploaded (by Mooeypoo):
Change event listener for caption surface in media dialog

https://gerrit.wikimedia.org/r/176028

Patch-For-Review

Mooeypoo claimed this task.Nov 26 2014, 8:06 PM
Jdforrester-WMF renamed this task from Changes in the caption surface in MediaDialog does not enable the "Apply" button to [Regression wmf10] Changes in the caption surface in MediaDialog does not enable the "Apply" button.Nov 26 2014, 8:06 PM
Jdforrester-WMF removed Mooeypoo as the assignee of this task.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

Change 176197 had a related patch set uploaded (by Mooeypoo):
Set panels after everything is initialized in media dialog

https://gerrit.wikimedia.org/r/176197

Patch-For-Review

Change 176197 merged by jenkins-bot:
Set panels after everything is initialized in media dialog

https://gerrit.wikimedia.org/r/176197

Change 176704 had a related patch set uploaded (by Jforrester):
Set panels after everything is initialized in media dialog

https://gerrit.wikimedia.org/r/176704

Patch-For-Review

Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Dec 1 2014, 6:50 PM

Change 176704 merged by jenkins-bot:
Set panels after everything is initialized in media dialog

https://gerrit.wikimedia.org/r/176704

Change 176028 merged by jenkins-bot:
Change event listener for caption surface in media dialog

https://gerrit.wikimedia.org/r/176028