Page MenuHomePhabricator

Allow to start translations using a redirected article as title
Closed, ResolvedPublic1 Estimated Story Points

Description

When creating a new article, users are able to select articles using the name of a redirect, however they will get a blank page instead of the article when they try to translate.

For example, in Spanish Wikipedia, "Tomate" ("tomato" in English) is a redirect to "Solanum lycopersicum" (scientific name for tomato). In Content Translation I am allowed to start a translation for "tomate" but I get an empty page because it is a redirect. I would expect to be presented with the article content to translate regardless of me typing the final name or a redirected name.

This was reported at https://www.mediawiki.org/wiki/Topic:S5khw1l0nd98dfh6 (I recalled adding the info to Mingle, but I have not found it later, so I created this Phabricator card)

For extra flexibility starting translations we may want also to accept URL-encoded names (allowing users to start a translation by writing "Kuala_Lumpur" or "Kuala Lumpur" in the new translation dialog).

Event Timeline

Pginer-WMF raised the priority of this task from to Needs Triage.
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF added a project: ContentTranslation.
Pginer-WMF changed Security from none to None.
Pginer-WMF added a subscriber: Pginer-WMF.
Amire80 triaged this task as Medium priority.Dec 11 2014, 8:37 AM

New translation dialog will not allow you to choose a title which is a redirect. See screenshot.

pasted_file (332×701 px, 39 KB)

This is consistent with the search api results
https://es.wikipedia.org/w/api.php?action=opensearch&format=json&search=Tomate&namespace=0&suggest=

The blank page used to happen when translators land in translation view without translation selector validations. Blank page came from http://parsoid.wmflabs.org/eswiki/Tomate output -Parsoid does not resolve redirects(See T47808)

But, Another example: http://parsoid.wmflabs.org/enwiki/OLPC - This get listed in translation selector(why?)

The parsoid output is not null, it has information about the redirect target. May be we can take the user through the translation centre once again with the redirect target title? Means, if OLPC is chosen, when translate button is pressed, the user goes to translation view, translation view get information about redirect from Parsoid, redirect the user to page=One_Laptop_per_Child

Another option is to do this redirect validation at selector before enabling the "start translation" button. But I prefer less validations there and allow users to start something.

New translation dialog will not allow you to choose a title which is a redirect.

This is better than leading users to a blank page, but user expectation is to be able to start translating that article.

Instead of showing a warning or any kind of confirmation, we should aim for making it transparent. That is, if R is a redirect of A, selecting R and pressing "start translation" should have the same result as if I selected A and pressed "start translation". I think that is what you are referring to with:

May be we can take the user through the translation centre once again with the redirect target title? Means, if OLPC is chosen, when translate button is pressed, the user goes to translation view, translation view get information about redirect from Parsoid, redirect the user to page=One_Laptop_per_Child

Amire80 raised the priority of this task from Medium to High.Jan 1 2015, 10:31 AM

@Pginer-WMF:

If we automatically go to A if the user selects R and presses "start translation," what should we do with regard to the title? Should we show the R title they selected or the A title that belongs with the article text?

@Jsahleen I would say keeping what is related to the initial selection. That I think will bring the least surprise since it represents how the user thinks on the topic.

When the user selects a topic to translate there is an implicit or explicit translation title the user agrees on. For that piece of information we make some checks and inform the user on relevant warnings such as the title already existing on the target Wikipedia. So changing it automatically may be both unexpected and problematic from my point of view.

In addition, naming policies vary between Wikipedia editions so the automatic change is not guaranteed to meet better the target wiki policy.

gerritbot added a subscriber: gerritbot.

Change 189715 had a related patch set uploaded (by Nikerabbit):
Silently resolve redirect when starting translation

https://gerrit.wikimedia.org/r/189715

Patch-For-Review

Change 189715 merged by jenkins-bot:
Silently resolve redirect when starting translation

https://gerrit.wikimedia.org/r/189715

Copying from my email:

I also left in the air whether it
should be improved further, for example by showing a warning "The
actual page that will be translated is $canonical, because the source
page redirects there."

Needs @Pginer-WMF to verify on the improvements about the warning display

I tried the change locally and the redirect dealing works, but there is an issue with the target article title.

As I commented above, if the user leaves the target title empty the expectation it to have the same title as the user wrote for the source title. With the current behaviour, if I translate "Tomatera" (which is a redirect), I get both the source and target titles changed to "Solanum lycopersicum". While changing the source title is a way to communicate the redirect, changing the target is overriding a user decision (should be avoided) and may lead to unexpected name conflict issues.

verify on the improvements about the warning display

@Arrbee Not sure which improvements do I need to verify (I have not seen any change in the warnings). If you refer to the idea of adding extra warnings, I think they are not needed here. Let's treat redirects as valid aliases for a topic. I don't see the need to warn the user about this.

Change 190639 had a related patch set uploaded (by Nikerabbit):
Replace empty target title with original input

https://gerrit.wikimedia.org/r/190639

Patch-For-Review

Change 190639 merged by jenkins-bot:
Replace empty target title with original input

https://gerrit.wikimedia.org/r/190639