Page MenuHomePhabricator

add language fallback to entity search/suggester (wbsearchentities)
Closed, ResolvedPublic

Description

The search box and entity suggester should make use of language fallback. It should be consistent with the language fallback chain used for the entity view.

Event Timeline

Lydia_Pintscher raised the priority of this task from to Medium.
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher changed Security from none to None.
Lydia_Pintscher added a subscriber: Lydia_Pintscher.
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).

From my point of view this is quite a regression. Consider the following setting:

  • P1 has a label in en, and no label in de
  • Q1 has a statement on P1
  • Q2 has no statement on P1
  • UI language is de

A user takes a look at Q1, sees the fallback label, understands it and wants to add a statement for this property on Q2. The entity suggester would not allow her to do it via fallback label. Previously, she would have seen the property id in the statement on Q1, which the entity suggester would have allowed.

I am not sure I understand, @adrianheine. When adding a new statement the fallback would be taken into account as well. That's the point of this ticket ;-) Or am I misunderstanding your example?

I meant the current state is a regression. We broke a use-case I consider somewhat reasonable. This task would fix that.

Lydia_Pintscher raised the priority of this task from Medium to High.Mar 12 2015, 1:43 PM
daniel renamed this task from add language fallback to entity search/suggester to add language fallback to entity search/suggester (wbsearchentities).Apr 13 2015, 11:05 AM

Change 203805 had a related patch set uploaded (by Daniel Kinzler):
Enable language fallback in wbsearchentities.

https://gerrit.wikimedia.org/r/203805

Change 203805 merged by jenkins-bot:
Enable language fallback in wbsearchentities.

https://gerrit.wikimedia.org/r/203805