Page MenuHomePhabricator
Create Task
Maniphest T76193

Username links are red, when user pages that exists globally (GlobalUserPage) but not locally are seen in Flow
Closed, ResolvedPublic
Actions

Description

I have a GlobalUserPage at http://en.wikipedia.beta.wmflabs.org/wiki/User:Quiddity
but there's a red link to my username at http://en.wikipedia.beta.wmflabs.org/wiki/Topic:S6hw6r3zb44q1k2a
It works fine for the link to my username in http://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Quiddity

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/GlobalUserPagemaster+9 -22Hook into TitleIsAlwaysKnown instead of LinkBegin
mediawiki/extensions/Flowmaster+2 -2Use isKnown instead of exists for user/user talk links in API
Customize query in gerrit

Related Objects

Event Timeline

Quiddity created this task.Nov 28 2014, 7:59 AM
Quiddity renamed this task from userpage tab is red, when seen in Flow to username links is red, when seen in Flow.
Quiddity raised the priority of this task from to Medium.
Quiddity updated the task description. (Show Details)
Quiddity added a project: GlobalUserPage.
Quiddity changed Security from none to None.
Quiddity added a subscriber: Quiddity.
Aklapper added a project: StructuredDiscussions.Dec 3 2014, 4:23 PM
EBernhardson added a subtask: T75426: Comments containing diacritics does not generate notifications.Dec 3 2014, 6:52 PM
EBernhardson removed a subtask: T75426: Comments containing diacritics does not generate notifications.
• Mattflaschen-WMF added a subscriber: • Mattflaschen-WMF.Dec 3 2014, 8:11 PM

Compare to http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Wikipedia:Sandbox&oldid=165437 (blue).

Is there a timeline for WMF deployment of GlobalUserPage?

Legoktm added a subscriber: Legoktm.Dec 3 2014, 8:14 PM
In T76193#808349, @Mattflaschen wrote:

Is there a timeline for WMF deployment of GlobalUserPage?

Not yet, T76410 is currently blocking deployment.

• Mattflaschen-WMF renamed this task from username links is red, when seen in Flow to Username links are red, when a user page that exists globally (GlobalUserPage) but not locally is seen in Flow.Dec 9 2014, 3:22 AM
• Mattflaschen-WMF renamed this task from Username links are red, when a user page that exists globally (GlobalUserPage) but not locally is seen in Flow to Username links are red, when user pages that exists globally (GlobalUserPage) but not locally are seen in Flow.
Nemo_bis added a subscriber: Nemo_bis.Jan 30 2015, 9:44 AM

Flow is used in a negligible amount of pages, so this bug is most definitely not blocking deployment of GlobalUserPage. It does look like something Flow devs should fix, though.

Nemo_bis removed a parent task: T72576: Review and deploy GlobalUserPage extension to Wikimedia wikis.Jan 30 2015, 9:44 AM
• Mattflaschen-WMF claimed this task.Jan 31 2015, 4:28 AM
gerritbot added a project: Patch-For-Review.Feb 3 2015, 4:41 AM
gerritbot added a subscriber: gerritbot.

Change 188298 had a related patch set uploaded (by Mattflaschen):
Hook into TitleIsAlwaysKnown instead of LinkBegin

https://gerrit.wikimedia.org/r/188298

Patch-For-Review

gerritbot added a comment.Feb 3 2015, 4:43 AM

Change 188299 had a related patch set uploaded (by Mattflaschen):
Use isKnown instead of exists for user/user talk links in API

https://gerrit.wikimedia.org/r/188299

Patch-For-Review

• Mattflaschen-WMF added a subscriber: tstarling.Feb 4 2015, 12:19 AM
• Mattflaschen-WMF reassigned this task from • Mattflaschen-WMF to Legoktm.Feb 4 2015, 12:59 AM

@tstarling @Legoktm, and I have been discussing alternative ways to implement this, more conducive to batching the ultimate query required. Essentially, this would be a batched version of Title::isKnown().

A couple of specific locations discussed:

  • Subclass of or composition relationship with LinkBatch.
  • Refactored version of replaceInternal at LinkHolderArray. Tim's idea is basically to separate the existence/known logic from the parser-specific stuff (like replacing "<!--LINK $key-->").

@Legoktm said he was going to work on the batching, so assigning to him.

gerritbot added a comment.Feb 13 2015, 2:53 PM

Change 188299 merged by jenkins-bot:
Use isKnown instead of exists for user/user talk links in API

https://gerrit.wikimedia.org/r/188299

• Mattflaschen-WMF mentioned this in rEFLW60bf9487c217: Use isKnown instead of exists for user/user talk links in API.Feb 13 2015, 2:53 PM
gerritbot added a comment.Feb 17 2015, 7:53 PM

Change 188298 merged by jenkins-bot:
Hook into TitleIsAlwaysKnown instead of LinkBegin

https://gerrit.wikimedia.org/r/188298

Legoktm mentioned this in rEGUP78bbe09e013a: Hook into TitleIsAlwaysKnown instead of LinkBegin.Feb 17 2015, 7:53 PM
Legoktm added a comment.Feb 17 2015, 7:54 PM

I filed T88644 for the batching.

Legoktm closed this task as Resolved.Feb 17 2015, 7:54 PM
Legoktm reassigned this task from Legoktm to • Mattflaschen-WMF.
Diffusion mentioned this in rMEXTb982f4f3a091: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:26 AM
• Mattflaschen-WMF mentioned this in rMEXT56ef63ef7877: Updated mediawiki/extensions Project: mediawiki/extensions/GlobalUserPage….Mar 11 2015, 6:26 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL