Page MenuHomePhabricator

Language labels should have the same height
Closed, ResolvedPublic

Assigned To
Authored By
Amire80
Dec 1 2014, 10:44 AM
Referenced Files
F18195: צילום_מסך_מ־2014-12-03_12:26:35.png
Dec 3 2014, 10:27 AM
F17832: pasted_file
Dec 2 2014, 4:12 AM
F17711: צילום_מסך_מ־2014-12-01_13:21:50.png
Dec 1 2014, 11:53 AM
F17710: צילום_מסך_מ־2014-12-01_13:21:54.png
Dec 1 2014, 11:53 AM
F17707: pasted_file
Dec 1 2014, 11:13 AM
F17705: pasted_file
Dec 1 2014, 11:03 AM

Description

See here:

http://en.wikipedia.beta.wmflabs.org/wiki/Special:ContentTranslation?page=Property&from=en&to=pa

This may be related to the fact that Punjabi and some other languages of India have a larger line-height in core.

Event Timeline

Amire80 raised the priority of this task from to High.
Amire80 updated the task description. (Show Details)
Amire80 changed Security from none to None.
Amire80 subscribed.

Change 176644 had a related patch set uploaded (by Santhosh):
Avoid veritical misalignment of language labels in column headers

https://gerrit.wikimedia.org/r/176644

Patch-For-Review

I haven't actually run it myself yet, but I see in the screnshot that the word "English" is cut at the bottom.

This doesn't resolve the bug for me. Compare the alignment of paragraphs between Punjabi and Russian in the screenshots.

צילום_מסך_מ־2014-12-01_13:21:54.png (900×1 px, 164 KB)

צילום_מסך_מ־2014-12-01_13:21:50.png (900×1 px, 209 KB)

Alignment analysis for the Screenshot by Amir

pasted_file (587×949 px, 243 KB)

Could you please explain where the alignment went wrong here?

The patch fixes the issue for me. Can you Amir check which font the Punjabi autonym is using?

The Russian screenshot is the good one, so the red lines align.

Here's what I see in Punjabi:

צילום_מסך_מ־2014-12-03_12:26:35.png (900×1 px, 340 KB)

Notice that the category tag icon is lower.

Change 176644 abandoned by Santhosh:
Avoid vertical misalignment of language labels in column headers

Reason:
Amir will work on a better solution

https://gerrit.wikimedia.org/r/176644

Arrbee renamed this task from When translating to Punjabi, the sections in Special:CX are misaligned to Language labels should have the same height.Dec 18 2014, 1:31 PM