In T69180#798753, @csteipp wrote:We'll deploy that fix, and then work on a better solution-- in general, .html() should rarely be used and I'd rather see this fixed with something like (after you remove the leading instance of the page title from page.extract),
$contentbox.append( $('<b></b>').text( page.title ) );
$contentbox.append( $('<span></span>').text( page.extract ) );
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove the need of .html in article.getProcessedHtml | mediawiki/extensions/Popups | master | +61 -24 |
Related Objects
Related Objects
Event Timeline
Comment Actions
We don't want to add the title at the beginning of the extract but to bold every instance of it. I see what you mean though, and have submitted a patch that removes the need to use .html().
It does however do some string mangling that I am not very comfortable with.
Comment Actions
Change 176908 had a related patch set uploaded (by Prtksxna):
Remove the need of .html in article.getProcessedHtml
Comment Actions
It does however do some string mangling that I am not very comfortable with.
I feel better about this after seeing @csteipp's comment on the patch.
Comment Actions
Change 176908 merged by jenkins-bot:
Remove the need of .html in article.getProcessedHtml