Page MenuHomePhabricator
Create Task
Maniphest T76461

WYSIWYG extension tries to use protected variable styles of includes/OutputPage.php in MW1.24
Closed, DeclinedPublic
Actions

Description

In MW 1.24 variable styles which is defined in includes/OutputPage.php has been changed from public to protected. Because of this there is now a problem with MW extension:wysiwyg where BeforePageDisplay hook is trying to use $out->styles variable (using function onBeforePageDisplay): result is fatal error and extension will not start.

So far workarounds which I have been able to find are change type of variable "styles" back to "public" in OutputPage.php of MW or comment out lines ~191-211 in CKeditor.body.php of wysiwg.

With my limited skills of PHP programming, I have been unsuccessful with my attempts to "extend" visibility of protected variable "styles" from OutputPage.php to wysiwyg. Is it possible to solve this in code of extension somehow?

For a similar case about styles, see T76461.
For a similar case about mCoreRights, see T76264.
For a similar case about mLinktags, see T76168.

Related Objects

Event Timeline

riparap created this task.Dec 2 2014, 12:56 PM
riparap raised the priority of this task from to Needs Triage.
riparap updated the task description. (Show Details)
riparap added a project: MediaWiki-extensions-General.
riparap changed Security from none to None.
riparap subscribed.
Aklapper added a subscriber: siebrand.Dec 2 2014, 1:33 PM

That change was done in https://git.wikimedia.org/commit/mediawiki%2Fcore.git/df49428b90ecfee7e9e7e9ffdcaca440a4375b50
Adding the patch author here.

Aklapper triaged this task as Lowest priority.Dec 2 2014, 1:36 PM

Also note that the comment above that line has been saying "For internal use; add settings in the skin via $this->addStyle()" since 2008 so this would be something to fix in the WYSIWYG extension instead.

I have no idea where the maintainers of https://www.mediawiki.org/wiki/Extension:WYSIWYG track their bugs as there are no hints on their wikipage so you might not receive much attention in this ticket.

https://www.mediawiki.org/wiki/Extension_talk:WYSIWYG#Protected_variable_.24styles_of_MW_1.24_vs._CKeditor.body.php_51135 might be the better place for the time being.

Aklapper renamed this task from Protected variable styles of includes/OutputPage.php in MW1.24 vs. extension using it to WYSIWYG extension tries to use protected variable styles of includes/OutputPage.php in MW1.24.Dec 2 2014, 1:42 PM
Aklapper mentioned this in T76168: Unable to access $OutputPage::mLinktags from extensions since MW 1.24 (changed to "protected").Dec 3 2014, 3:54 PM
Aklapper mentioned this in T76264: User::$mCoreRights made protected in 1.24, breaking stuff.Dec 3 2014, 4:37 PM
Aklapper updated the task description. (Show Details)
Legoktm subscribed.Dec 3 2014, 5:51 PM

IMO the WYSIWYG extension needs to be fixed, OutputPage::styles is not meant for public usage and was documented as so.

Florian subscribed.Dec 15 2014, 7:24 AM
In T76461#807601, @Legoktm wrote:

IMO the WYSIWYG extension needs to be fixed

+1

In T76461#801304, @Aklapper wrote:

I have no idea where the maintainers of https://www.mediawiki.org/wiki/Extension:WYSIWYG track their bugs as there are no hints on their wikipage so you might not receive much attention in this ticket.

So i think this ticket can be closed?

Aklapper edited projects, added MediaWiki-extensions-Other; removed MediaWiki-extensions-General.Dec 15 2014, 10:56 AM

I'd keep this here as this task is under WYSIWYG (well, "extensions-other"). Though likely nobody will see it...

riparap added a comment.Dec 15 2014, 3:07 PM

Details of the problem can be found here: https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Protected_variable_styles_of_includes/OutputPage.php_vs._extension_using_it

I have two question:

  1. Is it still possible to do current actions of wysiwyg onBeforePageDisplay hook using functions that inludes/OuputPage offers?
  2. With latest available browser versions, is there still a need for this kind of style sheet processing that hook onBeforePageDisplay of wysiwyg is doing?
MarkAHershberger subscribed.Dec 16 2014, 6:33 PM
Ricordisamoa subscribed.Dec 29 2014, 1:13 AM
Pppery closed this task as Declined.Feb 4 2023, 5:02 AM
Pppery subscribed.

Extension was archived.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits