move formatters into own directory
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Lydia_Pintscher
	Dec 2 2014, 2:13 PM

Description

We need to move the formatters into their own directory in order to then split them out into a separate repository.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make TypedValueFormatter interface/implementations PSR-4 compatible	mediawiki/extensions/Wikibase	master	+9 -7

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	None	T75863 [Task] Split wikibase.git
Declined	None	T75871 move formatters into their own repository
Open	None	T108296 [Epic] Remove WikibaseLib
Declined	None	T76469 move formatters into own directory

Event Timeline

Lydia_Pintscher created this task.Dec 2 2014, 2:13 PM

Lydia_Pintscher raised the priority of this task from to Medium.

Lydia_Pintscher updated the task description. (Show Details)

Lydia_Pintscher added projects: Wikidata, MediaWiki-extensions-Wikibase-Repo.

Lydia_Pintscher changed Security from none to None.

Lydia_Pintscher subscribed.

JeroenDeDauw added a parent task: T108296: [Epic] Remove WikibaseLib.Aug 7 2015, 9:00 AM

Ricordisamoa subscribed.Aug 8 2015, 11:19 PM

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Apr 23 2017, 5:16 PM

I did a find and grep and found that all classes with the word "formatter" are already in directories called "Formatter", with pretty much no exceptions:

lib/includes/TypedValueFormatter.php
repo/includes/SummaryFormatter.php

And a few that are in other subdirectories (and belong there):

client/includes/RecentChanges/ChangeLineFormatter.php
client/includes/Usage/UsageTrackingSnakFormatter.php
repo/includes/Diff/DiffOpValueFormatter.php
repo/includes/Localizer/MessageParameterFormatter.php

I believe this task is underspecified. It's also not a pre-requisite to move classes to a directory before they can be moved to a separate component. Therefor I suggest to close this ticket as invalid.

Change 349976 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Make TypedValueFormatter interface/implementations PSR-4 compatible

https://gerrit.wikimedia.org/r/349976

gerritbot added a project: Patch-For-Review.Apr 24 2017, 4:38 PM

Change 349976 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make TypedValueFormatter interface/implementations PSR-4 compatible

https://gerrit.wikimedia.org/r/349976

Ladsgroup removed a project: Patch-For-Review.Jul 19 2017, 12:13 PM

thiemowmde closed this task as Declined.Aug 3 2017, 8:27 AM

Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptAug 3 2017, 8:27 AM