Page MenuHomePhabricator

move formatters into own directory
Closed, DeclinedPublic

Description

We need to move the formatters into their own directory in order to then split them out into a separate repository.

Related Objects

StatusAssignedTask
OpenNone
DeclinedNone
OpenNone
DeclinedNone

Event Timeline

Lydia_Pintscher raised the priority of this task from to Normal.
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher changed Security from none to None.
Lydia_Pintscher added a subscriber: Lydia_Pintscher.

I did a find and grep and found that all classes with the word "formatter" are already in directories called "Formatter", with pretty much no exceptions:

lib/includes/TypedValueFormatter.php
repo/includes/SummaryFormatter.php

And a few that are in other subdirectories (and belong there):

client/includes/RecentChanges/ChangeLineFormatter.php
client/includes/Usage/UsageTrackingSnakFormatter.php
repo/includes/Diff/DiffOpValueFormatter.php
repo/includes/Localizer/MessageParameterFormatter.php

I believe this task is underspecified. It's also not a pre-requisite to move classes to a directory before they can be moved to a separate component. Therefor I suggest to close this ticket as invalid.

Change 349976 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Make TypedValueFormatter interface/implementations PSR-4 compatible

https://gerrit.wikimedia.org/r/349976

Change 349976 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make TypedValueFormatter interface/implementations PSR-4 compatible

https://gerrit.wikimedia.org/r/349976

thiemowmde closed this task as Declined.Aug 3 2017, 8:27 AM
Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptAug 3 2017, 8:27 AM