| Amire80 | |
| Dec 2 2014, 2:48 PM |
| F168548: VisualEditorBug2b.png | |
| May 24 2015, 11:42 AM |
| F168546: VisualEditorBug2a.png | |
| May 24 2015, 11:42 AM |
The Page options menu, which appears when the "hamburger" button is clicked, goes off-screen in RTL wikis.
Screenshot with wrong display in Hebrew:
https://commons.wikimedia.org/wiki/File:VisualEditorBug2a.png
Screenshot with correct display in English:
https://commons.wikimedia.org/wiki/File:VisualEditorBug2b.png
(I have a vague recollection that I reported it once, but I cannot find it now. If somebody does find it, please mark this one as a dupe.)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdforrester-WMF | T53792 VisualEditor: Non-English Wikipedia issues (tracking) | |||
| Invalid | Jdforrester-WMF | T35077 VisualEditor multilingual input / i18n issues (tracking) | |||
| Resolved | Jdforrester-WMF | T35126 VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) | |||
| Resolved | matmarex | T76474 VisualEditor page options menu goes off-screen in RTL wikis |
Change 179565 had a related patch set uploaded (by Amire80):
Add noflip to oo-ui-popupToolGroup-left and -right
Setting appropriate left and right values for oo-ui-popupToolGroup-left and oo-ui-popupToolGroup-right by adding noflip seems to fix the issue, but because I'm not an experienced oojs-ui dev, this needs review.
For now I fixed this locally in he.wikipedia by adding:
.oo-ui-popupToolGroup-left > .oo-ui-toolGroup-tools {
left: 0;
right: auto;
}The real issue is that ClippableElement doesn't handle clipping with the left edge of browser window, only with the right edge.
Change 179581 had a related patch set uploaded (by Bartosz Dziewoński):
[WIP] ClippableElement: Handle clipping with left edge
Change 179565 abandoned by Amire80:
Add noflip to oo-ui-popupToolGroup-left and -right
Reason:
Done better in I0c2d9800a1c0bdbe523c978307546ec205202681 .
Change 179581 merged by jenkins-bot:
ClippableElement: Handle clipping with left edge