"ImageMagick" SVG converter shouldn't use "-background white", but "transparent". No idea why this is done this way, changing it didn't break anything for me, but I assume there's a reason. Right now we can't rasterize SVGs for T76473 without losing transparency…
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use transparent rather than white background for ImageMagick SVG thumbnails | mediawiki/core | master | +3 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core | |||
| Open | None | T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core | |||
| Resolved | matmarex | T74715 Convert some MW core special pages to OOUI | |||
| Resolved | • TrevorParscal | T74714 Provide the OOUI PHP module inside MW core | |||
| Declined | None | T72932 MediaViewer does not support IE8 | |||
| Declined | None | T77343 IE6-8 compatibility | |||
| Declined | None | T72933 SVG icons in MediaViewer should have a fallback | |||
| Resolved | matmarex | T76473 Implement ResourceLoader module to ship CSS for sets of SVG+PNG icons to the user | |||
| Resolved | matmarex | T76475 "ImageMagick" SVG converter shouldn't use "-background white", but "transparent" |
Event Timeline
Comment Actions
Possible guess (without looking at code): work around ie6 png transparency bug. -background controls both the rendering background and the png fallback if alpha not supported background.
If that is the case, i believe its possible to specify both independently using the switch multiple times.
Comment Actions
I did some research and experimenting. Brian's guess seems correct and his proposed solution seems to work.
I took this SVG file:
(source: https://commons.wikimedia.org/wiki/File:WikiFont_signature_icon.svg), uploaded to a testing wiki and rasterized with the following options in $wgSVGConverters['ImageMagick']:
- -background white: F37591 – result: opaque white background
- -background transparent: F37593 – result: transparent background, renders as solid black square using IE6 on WinXP
- -background "#ffffff00": F37595 – result: transparent background, renders with opaque white background using IE6 on WinXP
So, here's a patch to change the default to the last version.
Comment Actions
Change 188857 had a related patch set uploaded (by Bartosz Dziewoński):
Use transparent rather than white background for ImageMagick SVG thumbnails
Comment Actions
Change 188857 merged by jenkins-bot:
Use transparent rather than white background for ImageMagick SVG thumbnails