Page MenuHomePhabricator
Create Task
Maniphest T76518

Errors in Parsoid v2 entry point
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

We are just starting to do some mass testing through restbase, and noticed failures from Parsoid when using the v2 GET entry point. Test cases:

Details

SubjectRepoBranchLines +/-
Fix failures from v2 endpointmediawiki/services/parsoidmaster+13 -13
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT78676 Store & load data-mw separately
ResolvedArlolraT76518 Errors in Parsoid v2 entry point
· · ·

Event Timeline

• GWicke created this task.Dec 2 2014, 8:36 PM
• GWicke raised the priority of this task from to Needs Triage.
• GWicke updated the task description. (Show Details)
• GWicke changed Security from none to None.
• GWicke added a project: Parsoid.
• GWicke edited subscribers, added: Arlolra; removed: Aklapper.
• GWicke subscribed.
Arlolra claimed this task.Dec 2 2014, 9:52 PM

Ah, this is from stripping at !topLevel pipelines. Fixing.

Arlolra triaged this task as High priority.Dec 2 2014, 9:52 PM
gerritbot added a project: Patch-For-Review.Dec 3 2014, 12:55 AM

Change 177142 had a related patch set uploaded (by Arlolra):
Fix failures from v2 endpoint

https://gerrit.wikimedia.org/r/177142

Patch-For-Review

gerritbot added a comment.Dec 3 2014, 1:53 AM

Change 177142 merged by jenkins-bot:
Fix failures from v2 endpoint

https://gerrit.wikimedia.org/r/177142

Arlolra added a comment.Dec 3 2014, 1:56 AM

From the commit message,

Although this resolves the crashes, I'm unsatisfied with it as a
proper fix to the underlying issue. There are many places throughout
the codebase where we serialize and then parse document fragments
that should be instrumented to store and unpack data-* attributes.
Arlolra removed a project: Patch-For-Review.Dec 3 2014, 1:56 AM
ssastry moved this task from Needs Triage to In Progress on the Parsoid board.Dec 4 2014, 8:22 AM
• GWicke added a comment.Dec 8 2014, 4:20 PM

FWIW, I haven't seen any significant number of crashes since.

ssastry moved this task from In Progress to VE Q3 on the Parsoid board.Jan 31 2015, 1:19 AM
• marcoil added a project: VisualEditor 2014/15 Q3 blockers.Feb 10 2015, 2:58 PM
Jdforrester-WMF moved this task from Nominated to Dependencies on the VisualEditor 2014/15 Q3 blockers board.Feb 10 2015, 7:42 PM
Jdforrester-WMF edited a custom field.Feb 10 2015, 8:32 PM
Jdforrester-WMF added a project: Blocked-on-Parsoid.Feb 13 2015, 9:39 PM
Arlolra added a parent task: T78676: Store & load data-mw separately.Mar 5 2015, 9:20 PM
• GWicke added a comment.EditedMar 5 2015, 9:26 PM

@Arlolra, I think this issue can be closed. I reported the remaining crashers in a separate page (all long lists that time out). Can't find it right now though.

Edit: T88915

Arlolra added a comment.Mar 5 2015, 9:28 PM

@GWicke The crashers are fixed but the robustness mentioned in T76518#804047 hasn't. Should I close this an open another then?

Arlolra mentioned this in T91700: Store and unpack data-* attributes when serializing/parsing document fragments throughout the pipeline.Mar 5 2015, 9:43 PM

Opened T91700 for the robustness issue.

Arlolra closed this task as Resolved.Mar 5 2015, 9:44 PM
Jdforrester-WMF moved this task from Dependencies to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 5 2015, 9:45 PM
Jdforrester-WMF added a project: WMF-deploy-2015-03-04_(1.25wmf20).Mar 10 2015, 7:20 PM
Arlolra mentioned this in rGPAR7e855be1a475: Fix failures from v2 endpoint.Apr 8 2015, 4:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL