Errors in Parsoid v2 entry point
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To

Authored By

	• GWicke
	Dec 2 2014, 8:36 PM

Description

We are just starting to do some mass testing through restbase, and noticed failures from Parsoid when using the v2 GET entry point. Test cases:

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix failures from v2 endpoint	mediawiki/services/parsoid	master	+13 -13

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Open	None	T78676 Store & load data-mw separately
Resolved	Arlolra	T76518 Errors in Parsoid v2 entry point
		· · ·

Event Timeline

• GWicke created this task.Dec 2 2014, 8:36 PM

• GWicke raised the priority of this task from to Needs Triage.

• GWicke updated the task description. (Show Details)

• GWicke changed Security from none to None.

• GWicke added a project: Parsoid.

• GWicke edited subscribers, added: Arlolra; removed: Aklapper.

• GWicke subscribed.

Ah, this is from stripping at !topLevel pipelines. Fixing.

Arlolra triaged this task as High priority.Dec 2 2014, 9:52 PM

Change 177142 had a related patch set uploaded (by Arlolra):
Fix failures from v2 endpoint

https://gerrit.wikimedia.org/r/177142

Patch-For-Review

Change 177142 merged by jenkins-bot:
Fix failures from v2 endpoint

https://gerrit.wikimedia.org/r/177142

From the commit message,

Although this resolves the crashes, I'm unsatisfied with it as a
proper fix to the underlying issue. There are many places throughout
the codebase where we serialize and then parse document fragments
that should be instrumented to store and unpack data-* attributes.

Arlolra removed a project: Patch-For-Review.Dec 3 2014, 1:56 AM

ssastry moved this task from Needs Triage to In Progress on the Parsoid board.Dec 4 2014, 8:22 AM

FWIW, I haven't seen any significant number of crashes since.

ssastry moved this task from In Progress to VE Q3 on the Parsoid board.Jan 31 2015, 1:19 AM

• marcoil added a project: VisualEditor 2014/15 Q3 blockers.Feb 10 2015, 2:58 PM

Jdforrester-WMF moved this task from Nominated to Dependencies on the VisualEditor 2014/15 Q3 blockers board.Feb 10 2015, 7:42 PM

Jdforrester-WMF edited a custom field.Feb 10 2015, 8:32 PM

Jdforrester-WMF added a project: Blocked-on-Parsoid.Feb 13 2015, 9:39 PM

Arlolra added a parent task: T78676: Store & load data-mw separately.Mar 5 2015, 9:20 PM

@Arlolra, I think this issue can be closed. I reported the remaining crashers in a separate page (all long lists that time out). Can't find it right now though.

Edit: T88915

@GWicke The crashers are fixed but the robustness mentioned in T76518#804047 hasn't. Should I close this an open another then?